feat(catalog/sql): Add integration test for sql catalog #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laskoviymishka
suggested changes
Jun 4, 2025
catalog/sql/sql_integration_test.go
Outdated
| s.Require().NoError(s.cat.DropTable(s.ctx, catalog.ToIdentifier(TestNamespaceIdent, "test-table"))) | ||
| } | ||
|
|
||
| //func (s *SQLIntegrationSuite) TestCreateView() { |
Contributor
There was a problem hiding this comment.
use s.T().Skip("Wait for something")
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
dttung2905
force-pushed
the
add-integration-test-sql-catalog
branch
from
b702b5d to
8f971af
Compare
laskoviymishka
approved these changes
Jun 22, 2025
zeroshade
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR fixes #442
Will need the PR #414 to be merged first before I can uncomment one of the integration test case