Skip to content

ci: scope push trigger to main to drop redundant PR runs#802

Merged
wgtmac merged 1 commit into
apache:mainfrom
abnobdoss:ci/scope-push-triggers
Jul 4, 2026
Merged

ci: scope push trigger to main to drop redundant PR runs#802
wgtmac merged 1 commit into
apache:mainfrom
abnobdoss:ci/scope-push-triggers

Conversation

@abnobdoss

@abnobdoss abnobdoss commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Change

Make push triggers more consistent by having the test workflows run branch pushes only on main. Pull requests still run the same checks, and tag builds are unchanged.

The duplicate-run case is narrow: it only happens for branches pushed directly to the Apache repo, so it mostly affects committers and bots rather than normal fork-based contributors. Pull request checks cover those branch updates; direct main runs still give us post-merge CI and warm caches.

Also cleans up nearby on: sections so the triggers are easier to compare, including removing zizmor's redundant all-branches pull request filter.

Validation

Checked that all workflow YAML files still parse.

Remaining Trigger Inconsistencies

These are intentional or out of scope, so this PR leaves them alone:

  • Test workflows still run on all tag pushes to preserve release behavior.
  • rc only runs on release-candidate tags.
  • pre-commit still runs on regular branch pushes because it is cheap.
  • docs, cpp-linter, license_check, and codeql keep their narrower rules.

Related discussion: #799.

@zhjwpku zhjwpku left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable, thanks for keeping improve the CI workflows :-)

@zhjwpku zhjwpku added the ready to merge This PR has been approved and it is ready to merge. label Jul 3, 2026

@wgtmac wgtmac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abnobdoss and @zhjwpku!

@wgtmac wgtmac merged commit 131f976 into apache:main Jul 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge This PR has been approved and it is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants