feat(io): add streaming FileIO support#641
Open
wgtmac wants to merge 1 commit intoapache:mainfrom
Open
Conversation
Introduce InputFile/OutputFile stream APIs and Arrow IO adapters so bundled Avro/Parquet readers and writers can work with generic FileIO implementations.
WZhuo
reviewed
May 6, 2026
Comment on lines
+139
to
+142
| { | ||
| std::lock_guard lock(mutex_); | ||
| ARROW_RETURN_NOT_OK(CheckOpenLocked()); | ||
| } |
Contributor
There was a problem hiding this comment.
It checked in the inner Read function, no need to check here.
| std::lock_guard lock(mutex_); | ||
| ARROW_RETURN_NOT_OK(CheckOpenLocked()); | ||
| } | ||
| auto bytes_to_read = position >= size_ ? 0 : std::min(nbytes, size_ - position); |
Contributor
There was a problem hiding this comment.
Should it return error if position > size_?
| : input_(std::move(input)) {} | ||
|
|
||
| Result<int64_t> Position() const override { | ||
| ICEBERG_RETURN_UNEXPECTED(CheckOpen()); |
Contributor
There was a problem hiding this comment.
We do the open check in InputStream/OutputStream, I think the open check in InputStreamAdapter/OutputStreamAdapter can be removed and call the inner stream directly.
Comment on lines
+531
to
+537
| if (length.has_value()) { | ||
| ICEBERG_ASSIGN_OR_RAISE(size, ToInt64Length(*length)); | ||
| ICEBERG_ASSIGN_OR_RAISE(input_file, io->NewInputFile(path, *length)); | ||
| } else { | ||
| ICEBERG_ASSIGN_OR_RAISE(input_file, io->NewInputFile(path)); | ||
| ICEBERG_ASSIGN_OR_RAISE(size, input_file->Size()); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (length.has_value()) { | |
| ICEBERG_ASSIGN_OR_RAISE(size, ToInt64Length(*length)); | |
| ICEBERG_ASSIGN_OR_RAISE(input_file, io->NewInputFile(path, *length)); | |
| } else { | |
| ICEBERG_ASSIGN_OR_RAISE(input_file, io->NewInputFile(path)); | |
| ICEBERG_ASSIGN_OR_RAISE(size, input_file->Size()); | |
| } | |
| if (length.has_value()) { | |
| ICEBERG_ASSIGN_OR_RAISE(input_file, io->NewInputFile(path, *length)); | |
| } else { | |
| ICEBERG_ASSIGN_OR_RAISE(input_file, io->NewInputFile(path)); | |
| } | |
| ICEBERG_ASSIGN_OR_RAISE(size, input_file->Size()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce InputFile/OutputFile stream APIs and Arrow IO adapters so bundled Avro/Parquet readers and writers can work with generic FileIO implementations.