fix[protocol-sd]: add register center params check#4048
Merged
Conversation
Member
yuluo-yx
commented
Mar 1, 2026
yuluo-yx
commented
- Fixed [BUG] <title> nacos 服务发现 #4046
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
license-eye has checked 4515 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1909 | 1 | 2605 | 0 |
Click to see the invalid file list
- hertzbeat-common-core/src/test/java/org/apache/hertzbeat/common/entity/job/protocol/RegistryProtocolTest.java
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
...core/src/test/java/org/apache/hertzbeat/common/entity/job/protocol/RegistryProtocolTest.java
Outdated
Show resolved
Hide resolved
yuluo-yx
commented
Mar 1, 2026
| @Override | ||
| public boolean isInvalid() { | ||
|
|
||
| // todo: add |
Member
Author
There was a problem hiding this comment.
i think we can improve on this later; there's so much more to it.
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
tomsun28
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.