HBASE-30252 hbase snapshot info display inaccurate snapshot TTL information messages#8403
Open
guluo2016 wants to merge 1 commit into
Open
HBASE-30252 hbase snapshot info display inaccurate snapshot TTL information messages#8403guluo2016 wants to merge 1 commit into
hbase snapshot info display inaccurate snapshot TTL information messages#8403guluo2016 wants to merge 1 commit into
Conversation
…ormation messages
guluo2016
commented
Jun 23, 2026
| for (SnapshotDescription desc : getSnapshotList(conf)) { | ||
| System.out.printf("%-20s | %20s | %20s | %s%n", desc.getName(), | ||
| df.format(new Date(desc.getCreationTime())), desc.getTtl(), desc.getTableNameAsString()); | ||
| List<SnapshotDescription> snapshotDescriptions = getSnapshotList(conf); |
Member
Author
There was a problem hiding this comment.
I update the code here, moved this code before System.out.printf(...);
The reason is that getSnapshotList(conf) would print logs, breaking the display continuity of the snapshot list.
liuxiaocs7
approved these changes
Jun 23, 2026
| String ttlInfo = | ||
| desc.getTtl() == DEFAULT_SNAPSHOT_TTL ? TTL_FOREVER : String.valueOf(desc.getTtl()); | ||
| String expired = SnapshotDescriptionUtils.isExpiredSnapshot(desc.getTtl(), | ||
| desc.getCreationTime(), System.currentTimeMillis()) ? EXPIRED_LABEL : NOT_EXPIRED_LABEL; |
Member
There was a problem hiding this comment.
nit: do we need to move System.currentTimeMillis() outside the loop?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details see: HBASE-30252
In addition, I also added information about whether the snapshot has expired in the display. like PR #5947