HBASE-29863 Adding support for capturing files read during scan#7823
Open
Himanshu-g81 wants to merge 2 commits intoapache:masterfrom
Open
HBASE-29863 Adding support for capturing files read during scan#7823Himanshu-g81 wants to merge 2 commits intoapache:masterfrom
Himanshu-g81 wants to merge 2 commits intoapache:masterfrom
Conversation
NihalJain
changed the title
Contributor
Author
|
The single test (org.apache.hadoop.hbase.TestAcidGuaranteesWithBasicPolicy.null) failing in Yetus JDK17 Hadoop3 Unit Check / large-wave-1 during setup itself is unrelated to this PR and likely a flapper. Same test is failing (at same stage, i.e. cluster initialization) for other PRs as well, examples |
gvprathyusha6
approved these changes
Mar 6, 2026
Contributor
gvprathyusha6
left a comment
gvprathyusha6
left a comment
There was a problem hiding this comment.
Minor nits, otherwise LGTM
| RegionInfoBuilder.newBuilder(TableName.valueOf(name.getMethodName())).build(); | ||
| HRegionFileSystem regionFs = HRegionFileSystem.createRegionOnFileSystem(conf, fs, | ||
| new Path(testDir, hri.getTable().getNameAsString()), hri); | ||
| HFileContext meta = new HFileContextBuilder().withBlockSize(8 * 1024).build(); |
Contributor
There was a problem hiding this comment.
nit: variable name can be hfileContext
| Assert.assertEquals("Should have 0 files before closing", 0, filesReadBeforeClose.size()); | ||
|
|
||
| List<Cell> results = new ArrayList<>(); | ||
| InternalScanner storeScanner = (InternalScanner) kvScanner; |
Contributor
There was a problem hiding this comment.
can you use StoreScanner instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.