GUACAMOLE-1701: adding French translations#1051
Open
abesnier wants to merge 1 commit intoapache:mainfrom
Open
Conversation
abesnier
changed the title
corentin-soriano
requested changes
Jan 21, 2025
Member
corentin-soriano
left a comment
corentin-soriano
left a comment
There was a problem hiding this comment.
A minor change below.
You will also need to edit your commit message to correct the spelling error (transalations) and add a period.
abesnier
force-pushed
the
main
branch
2 times, most recently
from
b42674b to
bbf4237
Compare
Member
|
Since both commits are related to the same change and their messages are similar, can you squash them into one? |
Author
|
I believe modifications were done as requested (I am not good with git, sorry...) |
corentin-soriano
requested changes
Feb 9, 2025
Member
corentin-soriano
left a comment
corentin-soriano
left a comment
There was a problem hiding this comment.
Last little changes and it will be good!
| "translations" : [ | ||
| "translations/en.json" | ||
| "translations/en.json", | ||
| "translations/fr.json", |
Member
There was a problem hiding this comment.
Could you remove the comma at the end of this line which break the json?
| "TABLE_HEADER_DAY" : "Jour", | ||
| "TABLE_HEADER_END_TIME" : "Heure de fin", | ||
| "TABLE_HEADER_HOST" : "Hôte", | ||
| "TABLE_HEADER_START_TIME" : "Heure de début", |
Member
There was a problem hiding this comment.
Can you remove the comma at the end of this line too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created to add French transalations to the new restrict extension.
I've attached it to the main JIRA ticket at the base of this extension, as I don't think this would require a dedicated JIRA issue, but please advise if I 'm wrong.
Best regards
Antoine