Wire Neo4j adapter to GormRegistry's GormApiFactory mechanism (PR2)

[borinquenkid]

Summary

Completes the Neo4j GormRegistry migration plan's PR2, on top of the baseline migration in #15816: registers a Neo4jGormApiFactory so entities backed by Neo4jDatastore resolve a Neo4jGormStaticApi through GormRegistry instead of silently falling back to the generic GormStaticApi. Without this, static/cypher-string API calls (cypherStatic, findRelationship(s), findPath*, findShortestPath, find/findAll with a cypher string) threw ClassCastException or UnsupportedOperationException, since those methods only exist on Neo4jGormStaticApi.

This turned out to require far less than the "rewrite Neo4jEntity/Node/Relationship traits" originally scoped in the migration plan - a nice, concrete dividend of the GormRegistry refactor: adding a new datastore's wiring is now a small, mechanical exercise rather than an integration project. Neo4j's instance and validation APIs were already generic (GormInstanceApi/GormValidationApi, no Neo4j-specific subclass), matching DefaultGormApiFactory's base implementations already - only the static API needed a factory override, mirroring MongoGormApiFactory's exact shape (which only overrides createStaticApi() for the same reason). The whole change is a ~25-line factory class plus a single line registering it.

• Neo4jGormApiFactory#createStaticApi() resolves the datastore via DatastoreResolver#resolve() rather than Neo4j's old bespoke getDatastoreForQualifier()/datastoresByConnectionSource logic - qualifier/multi-datasource routing is now handled generically by GormRegistry/GormApiResolver (the O(M+N) scaling work this plan depends on). Verified this doesn't regress Neo4j's own multi-tenancy/multi-datasource tests.
• registerApiFactory() is called from Neo4jDatastore#initialize(), before constructing the GormEnhancer whose constructor eagerly registers this datastore's entities - registering after would leave those entities bound to the generic factory forever, since GormEnhancer only registers each entity once.
• 17 of the 34 tests marked @PendingFeature in the baseline PR now pass and had their annotations removed (ApiExtensionsSpec, CypherQueryStringSpec, OneToManyUpdateSpec, MultiTenancySpec, PathSpec, RelationshipSpec, NativeIdentityGeneratorSpec's saveAll test - whose fix was already in place from the baseline PR but unreachable until this factory was registered).

Test plan

• ./gradlew :grails-datastore-gorm-neo4j:test - BUILD SUCCESSFUL, 198/215 passing, 0 failures, 17 skipped (4 genuinely pending and unrelated to this change, plus pre-existing @Ignore'd tests)
• Verified no regressions in previously-passing tests, including multi-tenancy/multi-datasource specs, after switching to the generic DatastoreResolver-based routing

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Wires the Neo4j GORM adapter into the core GormRegistry API-factory mechanism so Neo4j-backed entities resolve Neo4jGormStaticApi (instead of falling back to the generic GormStaticApi), restoring Neo4j-specific static/cypher APIs and allowing previously-pending Neo4j specs to execute normally.

Changes:

• Add Neo4jGormApiFactory that overrides static API creation to return Neo4jGormStaticApi.
• Register the Neo4j API factory during Neo4jDatastore initialization before entity enhancement occurs.
• Remove @PendingFeature annotations from multiple Neo4j specs that now pass with the correct static API resolution.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/Neo4jGormApiFactory.groovy	Introduces a Neo4j-specific GormApiFactory that produces Neo4jGormStaticApi instances.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/Neo4jDatastore.java	Registers the Neo4j API factory early in datastore initialization to ensure entities bind to the Neo4j factory.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/org/grails/datastore/gorm/neo4j/ApiExtensionsSpec.groovy	Unblocks cypher query spec by removing @PendingFeature.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/CypherQueryStringSpec.groovy	Removes @PendingFeature from string/cypher static query tests now supported via Neo4jGormStaticApi.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/OneToManyUpdateSpec.groovy	Removes @PendingFeature now that cypherStatic resolves to the Neo4j static API.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/NativeIdentityGeneratorSpec.groovy	Removes @PendingFeature for saveAll now reachable via Neo4jGormStaticApi.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/multitenancy/MultiTenancySpec.groovy	Removes @PendingFeature now that cypher-string find resolves to Neo4j’s static API under multi-tenancy.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/path/PathSpec.groovy	Removes @PendingFeature for Neo4j path APIs now resolved from the correct static API.
grails-data-neo4j/grails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/path/RelationshipSpec.groovy	Removes @PendingFeature for relationship finder APIs now resolved from the correct static API.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.6341%. Comparing base (c024658) to head (e3015e4).

Additional details and impacted files

@@                          Coverage Diff                           @@
##             build/neo4j-groovy4-baseline     #15817        +/-   ##
======================================================================
+ Coverage                         49.6213%   49.6341%   +0.0128%     
- Complexity                          17032      17038         +6     
======================================================================
  Files                                1961       1961                
  Lines                               93738      93738                
  Branches                            16465      16465                
======================================================================
+ Hits                                46514      46526        +12     
+ Misses                              39983      39970        -13     
- Partials                             7241       7242         +1     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[testlens-app]

🚨 TestLens detected 1 failed test 🚨

Here is what you can do:

1. Inspect the test failures carefully.
2. If you are convinced that some of the tests are flaky, you can mute them below.
3. Finally, trigger a rerun by checking the rerun checkbox.

Test Summary

CI / Build Grails-Core (windows-latest, 25) > :grails-shell-cli:test

Test	Runs
RunningApplicationProcessSpec > stop terminates a running process and removes the PID file	❌

🏷️ Commit: c5ced04
▶️ Tests: 31679 executed
⚪️ Checks: 39/39 completed

Test Failures

RunningApplicationProcessSpec > stop terminates a running process and removes the PID file (:grails-shell-cli:test in CI / Build Grails-Core (windows-latest, 25))

Condition not satisfied:

!process.isAlive()
||       |
||       true
|Process[pid=5708, exitValue=1]
false

	at org.grails.cli.gradle.RunningApplicationProcessSpec.stop terminates a running process and removes the PID file(RunningApplicationProcessSpec.groovy:217)

Muted Tests

Select tests to mute in this pull request:

• RunningApplicationProcessSpec > stop terminates a running process and removes the PID file

Reuse successful test results:

• ♻️ Only rerun the tests that failed or were muted before

Click the checkbox to trigger a rerun:

• Rerun jobs

---

Learn more about TestLens at testlens.app.