Skip to content

Clarify exception resolver request logging metadata#15811

Merged
jdaugherty merged 1 commit into
7.0.xfrom
fix/request-logging-metadata-default
Jul 9, 2026
Merged

Clarify exception resolver request logging metadata#15811
jdaugherty merged 1 commit into
7.0.xfrom
fix/request-logging-metadata-default

Conversation

@jamesfredley

@jamesfredley jamesfredley commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The Problem

The runtime default for grails.exceptionresolver.logRequestParameters is environment-dependent: request-parameter logging is enabled in development and disabled everywhere else.

The Spring configuration metadata, however, advertised a single unconditional defaultValue. IDEs and config-metadata consumers that read that value would present a default that does not match what actually happens at runtime outside development.

The Fix

Make the published metadata tell the truth instead of a misleading constant.

  • Removed the unconditional metadata defaultValue.
  • Documented the real environment-dependent behavior (enabled in development, disabled otherwise) directly in the property description.

Files

  • grails-web-core/.../META-INF/spring-configuration-metadata.json - drop the hard-coded default, describe the dev/non-dev behavior.

Testing

  • :grails-web-core:processResources succeeds and the emitted metadata for grails.exceptionresolver.logRequestParameters has no defaultValue and carries the environment-dependent description.
  • LSP diagnostics clean for the metadata JSON.

Copilot AI review requested due to automatic review settings July 2, 2026 02:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Spring configuration metadata for grails.exceptionresolver.logRequestParameters to avoid advertising an unconditional default when the runtime default is environment-dependent, improving accuracy for IDE/config metadata consumers.

Changes:

  • Removed the unconditional defaultValue from grails.exceptionresolver.logRequestParameters metadata.
  • Updated the property description to document the development vs non-development default behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.4766%. Comparing base (66cd24c) to head (4febf42).
⚠️ Report is 5469 commits behind head on 8.0.x.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##                8.0.x     #15811        +/-   ##
==================================================
- Coverage     49.4842%   49.4766%   -0.0076%     
+ Complexity      16697      16695         -2     
==================================================
  Files            1947       1947                
  Lines           92474      92474                
  Branches        16152      16152                
==================================================
- Hits            45760      45753         -7     
- Misses          39606      39612         +6     
- Partials         7108       7109         +1     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jdaugherty jdaugherty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be made against 7.0.x

@jamesfredley jamesfredley changed the base branch from 8.0.x to 7.0.x July 9, 2026 18:51
The runtime default is environment-dependent: request parameters log in development and remain disabled otherwise. Remove the unconditional metadata default and describe the actual behavior.

Assisted-by: Hephaestus:openai/gpt-5.5 oracle codex-review
@jamesfredley jamesfredley force-pushed the fix/request-logging-metadata-default branch from 4febf42 to ba8156e Compare July 9, 2026 19:35
@testlens-app

testlens-app Bot commented Jul 9, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: ba8156e
▶️ Tests: 4056 executed
⚪️ Checks: 51/51 completed


Learn more about TestLens at testlens.app.

@jdaugherty jdaugherty merged commit 642bcd5 into 7.0.x Jul 9, 2026
51 of 52 checks passed
@jdaugherty jdaugherty deleted the fix/request-logging-metadata-default branch July 9, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants