Clarify exception resolver request logging metadata#15811
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Spring configuration metadata for grails.exceptionresolver.logRequestParameters to avoid advertising an unconditional default when the runtime default is environment-dependent, improving accuracy for IDE/config metadata consumers.
Changes:
- Removed the unconditional
defaultValuefromgrails.exceptionresolver.logRequestParametersmetadata. - Updated the property description to document the development vs non-development default behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.0.x #15811 +/- ##
==================================================
- Coverage 49.4842% 49.4766% -0.0076%
+ Complexity 16697 16695 -2
==================================================
Files 1947 1947
Lines 92474 92474
Branches 16152 16152
==================================================
- Hits 45760 45753 -7
- Misses 39606 39612 +6
- Partials 7108 7109 +1 🚀 New features to boost your workflow:
|
jdaugherty
left a comment
There was a problem hiding this comment.
This change should be made against 7.0.x
The runtime default is environment-dependent: request parameters log in development and remain disabled otherwise. Remove the unconditional metadata default and describe the actual behavior. Assisted-by: Hephaestus:openai/gpt-5.5 oracle codex-review
4febf42 to
ba8156e
Compare
✅ All tests passed ✅🏷️ Commit: ba8156e Learn more about TestLens at testlens.app. |
The Problem
The runtime default for
grails.exceptionresolver.logRequestParametersis environment-dependent: request-parameter logging is enabled in development and disabled everywhere else.The Spring configuration metadata, however, advertised a single unconditional
defaultValue. IDEs and config-metadata consumers that read that value would present a default that does not match what actually happens at runtime outside development.The Fix
Make the published metadata tell the truth instead of a misleading constant.
defaultValue.Files
grails-web-core/.../META-INF/spring-configuration-metadata.json- drop the hard-coded default, describe the dev/non-dev behavior.Testing
:grails-web-core:processResourcessucceeds and the emitted metadata forgrails.exceptionresolver.logRequestParametershas nodefaultValueand carries the environment-dependent description.