Conversation
jdaugherty
reviewed
Dec 16, 2025
Remove `META-INF/services/grails.factories` from `grails-web-url-mappings`. The file explicitly registers `UrlMappingsReportCommand`, but this is redundant: `GlobalGrailsClassInjectorTransformation` dynamically generates `META-INF/grails.factories` and automatically registers all `ApplicationCommand` implementations found in the source tree.
jdaugherty
approved these changes
Dec 17, 2025
If grails-web-urlmappings is on the build runtime classpath, its service-loader initialization will pre-register the `urlMappingsReport` task. This change adds a check to ensure the task is only registered once.
Use `getOrNull` and filter out null configurations to avoid potential issues during build classpath generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15286