[MINOR][VL] Add cudf build docker file with JDK 17 and cuda 12.9#11836
Open
jinchengchenghh wants to merge 3 commits intoapache:mainfrom
Open
[MINOR][VL] Add cudf build docker file with JDK 17 and cuda 12.9#11836jinchengchenghh wants to merge 3 commits intoapache:mainfrom
jinchengchenghh wants to merge 3 commits intoapache:mainfrom
Conversation
philo-he
changed the title
philo-he
changed the title
philo-he
changed the title
philo-he
reviewed
Mar 26, 2026
Member
philo-he
left a comment
philo-he
left a comment
There was a problem hiding this comment.
Some minor comments on names. Thank you!
Member
There was a problem hiding this comment.
Can we name it Dockerfile.centos9-cuda12.9-cudf which is compact and seems to be more readable?
| build-args: JAVA_VERSION=17 | ||
| file: dev/docker/cudf/Dockerfile.centos9-cudf-cuda-12-9 | ||
| push: true | ||
| tags: ${{ env.DOCKERHUB_REPO }}:centos-9-jdk17-cudf-cuda-12-9 |
Member
There was a problem hiding this comment.
Docker name suggestion: centos-9-jdk17-cuda12.9-cudf
Contributor
Author
There was a problem hiding this comment.
The docker name aligns with centos-9-jdk8-cudf, do you think I should also update the former?
Contributor
Author
There was a problem hiding this comment.
But for compatibility, I don't support to change the old name, then if the new image name should align with the former pattern? Looking for your suggestiion.
| push: true | ||
| tags: ${{ env.DOCKERHUB_REPO }}:centos-9-jdk8-cudf | ||
|
|
||
| build-centos-9-jdk17-cudf-cuda-12-9: |
Member
There was a problem hiding this comment.
build-centos-9-jdk17-cuda12.9-cudf:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the docker image
apache/gluten:centos-9-jdk17-cudf-cuda-12-9, installed the cudf related libraries in system library path.