Skip to content

[VL] Clean up GPU code: remove dead/redundant code #11824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acvictor wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −6
Open

[VL] Clean up GPU code: remove dead/redundant code #11824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions cpp/velox/cudf/GpuLock.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ void lockGpu() {
return;
}


// Wait until the GPU lock becomes available
getGpuLockState().gGpuCv.wait(lock, [] {
return !getGpuLockState().gGpuOwner.has_value();
Expand All @@ -72,12 +71,12 @@ void unlockGpu() {
std::thread::id tid = std::this_thread::get_id();
std::unique_lock<std::mutex> lock(getGpuLockState().gGpuMutex);
if (!getGpuLockState().gGpuOwner.has_value()) {
LOG(INFO) <<"unlockGpu() called by non-owner thread!"<< std::endl;
LOG(INFO) << "unlockGpu() called when no thread holds the lock!";
return;
}

if (!getGpuLockState().gGpuOwner.has_value() || getGpuLockState().gGpuOwner != tid) {
throw std::runtime_error("unlockGpu() called by other-owner thread!");
if (getGpuLockState().gGpuOwner != tid) {
throw std::runtime_error("unlockGpu() called by other thread!");
}

// Release ownership
Expand All @@ -88,5 +87,4 @@ void unlockGpu() {
getGpuLockState().gGpuCv.notify_one();
}


} // namespace gluten
1 change: 0 additions & 1 deletion cpp/velox/shuffle/VeloxGpuShuffleReader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ bool VeloxGpuHashShuffleReaderDeserializer::resolveNextBlockType() {
default:
throw GlutenException(fmt::format("Unsupported block type: {}", static_cast<int32_t>(blockType)));
}
return true;
}

void VeloxGpuHashShuffleReaderDeserializer::loadNextStream() {
Expand Down
Loading