feat: add ISO-GQL PROPERTY_EXISTS predicate (#359) #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement PROPERTY_EXISTS function according to ISO-GQL Section 19.13. Features: - ISO-GQL compliant PROPERTY_EXISTS predicate - Three-valued logic support (True/False/NULL) - Support for vertices, edges, and rows - Comprehensive unit tests and SQL test cases Implementation: - Add PropertyExists UDF class - Register function in BuildInSqlFunctionTable - Add PropertyExistsTest with 5 test cases (100% pass) - Add 3 SQL integration test cases Testing: - Unit tests: 5/5 passed - Checkstyle: 0 violations - Build: SUCCESS Closes apache#359
|
Hi @SeasonPilot. About this PR. I saw you just implement the simpify PROPERTY_EXISTS predicate. Will you add more change for this issue? |
…pache#359) Refactor PROPERTY_EXISTS to follow GeaFlow's established ISO-GQL predicate pattern by introducing PropertyExistsFunctions utility class. This aligns PropertyExists with IsSourceOf/IsDestinationOf implementation and addresses technical debt from the initial implementation. **Architecture Improvements:** - Add PropertyExistsFunctions utility class (three-layer pattern) * UDF → Utility → Business Logic - Delegate all eval() methods to utility class - Implement type validation with IllegalArgumentException - Add property name validation (null/empty checks) - Maintain ISO-GQL three-valued logic (NULL → null) **Error Handling:** - Invalid element type → clear error messages with type info - NULL/empty property name → descriptive error messages - Consistent with SourceDestinationFunctions error handling **Testing:** - Expand from 4 to 13 tests (+225% coverage) - Add 9 error handling tests: * Invalid element types (String, Integer) * NULL/empty/whitespace property names * Error message validation * Type-specific overload testing - All 13/13 tests pass **Code Quality:** - Checkstyle: 0 violations - Comprehensive Javadoc with ISO-GQL Section 19.13 reference - Design decision documentation - Implementation notes for Row interface limitations **Implementation Strategy:** - Runtime validation follows compile-time checking approach - Row interface indexed access documented - Future runtime schema validation options identified **Files:** - NEW: PropertyExistsFunctions.java (137 lines) - MOD: PropertyExists.java (refactored to delegation) - MOD: PropertyExistsTest.java (comprehensive tests) **Build Status:** - Tests: 13 run, 0 failures, 0 errors - Checkstyle: PASS - Build: SUCCESS
Contributor
Author
Hi @Manakaa ! Thanks for your attention to this PR. I've just pushed the refined/improved code for this issue, which includes the complete implementation of the PROPERTY_EXISTS predicate (beyond the initial simplified version). Feel free to review the latest commits when you have time. |
Contributor
Author
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement ISO-GQL PROPERTY_EXISTS predicate function according to Section 19.13 specification.
Core Changes:
org.apache.geaflow.dsl.udf.table.otherFeatures:
Test Coverage:
How was this PR tested?
Closes #359"