[lake/lance] Add Map type support for Lance#2949
Open
XuQianJin-Stars wants to merge 1 commit intoapache:mainfrom
Open
[lake/lance] Add Map type support for Lance#2949XuQianJin-Stars wants to merge 1 commit intoapache:mainfrom
XuQianJin-Stars wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
hi @wuchong @leekeiabstraction @luoyuxia Hi, i already updated the pr. Please help review when you got some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2403
Add Map type support for Lance lake storage. This enables Fluss tables with
MAPcolumns to be tiered into Lance format.Brief change log
MapTypeto ArrowMaptype conversion intoArrowField()andtoArrowType(). The Arrow Map structure follows the standard layout:Map -> entries(Struct) -> [key, value].MapVectordata copy logic incopyVectorData(). TheMapVectorcheck is placed beforeListVectorsinceMapVectorextendsListVector. AddedcopyMapVectorData()method which reusescopyListVectorData()logic due to shared memory layout.MapVectorinitialization logic ininitFieldVector().Tests
LanceArrowUtilsTest#testToArrowSchemaWithMapType- Basic Map type conversionLanceArrowUtilsTest#testToArrowSchemaWithMapOfComplexValueType- Map with Row value typeLanceArrowUtilsTest#testToArrowSchemaWithRowContainingMap- Nested Row containing MapLanceTieringTest#testTieringWriteTableWithMapType- Map type write and read unit testLanceTieringITCase#testTieringWithMapType- End-to-end integration test for Map typeAPI and Format
No API or storage format changes. This only extends the Lance lake storage plugin to support an additional Fluss data type (
MAP).Documentation
No documentation changes needed. This is an internal enhancement to the Lance lake storage plugin.