[rpc] Client zero-copy lazy parse ByteBuf to avoid deep memory copy#2948
Open
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Open
[rpc] Client zero-copy lazy parse ByteBuf to avoid deep memory copy#2948fresh-borzoni wants to merge 1 commit intoapache:mainfrom
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Conversation
fresh-borzoni
changed the title
Contributor
Author
|
@swuferhong @luoyuxia PTAL 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1184
Fix: each
DefaultCompletedFetch retains the parsedByteBufand releases indrain(). The response handler releases the base reference in finally. Netty refcounting keeps the buffer alive exactly until the last bucket's records are consumed.Effectively this is similar how it works in Rust SDK with Arc refcounting and Drop automatic release.
Both client paths now use zero-copy. isInnerClient flag removed as it was used only for this.