[lake/tiering] add total bytes read tracking and metrics for tiering service#2933
Open
beryllw wants to merge 2 commits intoapache:mainfrom
Open
[lake/tiering] add total bytes read tracking and metrics for tiering service#2933beryllw wants to merge 2 commits intoapache:mainfrom
beryllw wants to merge 2 commits intoapache:mainfrom
Conversation
beryllw
force-pushed
the
tiering-fluss-read-metrics
branch
from
5234a72 to
81ad388
Compare
beryllw
changed the title
beryllw
force-pushed
the
tiering-fluss-read-metrics
branch
from
707be6d to
88d22cb
Compare
...uss-flink-common/src/main/java/org/apache/fluss/flink/tiering/source/TieringSplitReader.java
Outdated
Show resolved
Hide resolved
luoyuxia
reviewed
Mar 30, 2026
...e/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/PaimonLakeWriter.java
Outdated
Show resolved
Hide resolved
luoyuxia
reviewed
Mar 30, 2026
fluss-common/src/main/java/org/apache/fluss/lake/writer/LakeWriter.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/metrics/MetricNames.java
Outdated
Show resolved
Hide resolved
|
|
||
| private final Counter writtenBytesCounter; | ||
|
|
||
| public TieringMetrics(SourceReaderMetricGroup sourceReaderMetricGroup) { |
Contributor
There was a problem hiding this comment.
so, this metrics is reported to flink metric, right? Is it same to flink cdc?
Contributor
Author
There was a problem hiding this comment.
Not quite the same. The tiering job keeps read and write in one operator (no shuffle), while Flink CDC introduces shuffle between the source and sink.
leonardBang
reviewed
Mar 30, 2026
...e/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/PaimonLakeWriter.java
Outdated
Show resolved
Hide resolved
...flink-common/src/main/java/org/apache/fluss/flink/tiering/source/metrics/TieringMetrics.java
Outdated
Show resolved
Hide resolved
beryllw
force-pushed
the
tiering-fluss-read-metrics
branch
from
f234e83 to
5c3992c
Compare
- Removed LakeWriter from test coverage exclusion list in pom.xml - Deleted testTotalBytesRead method from ScanRecordsTest class - Cleaned up redundant test cases for total bytes read functionality - Updated test suite to align with current code coverage requirements
beryllw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…jobs
Purpose
Linked issue: close #2932
Brief change log
Tests
API and Format
Documentation