[helm] Enable SASL authenticated connection to Zookeeper nodes#2700
Merged
polyzos merged 1 commit intoapache:mainfrom Mar 29, 2026
Merged
[helm] Enable SASL authenticated connection to Zookeeper nodes#2700polyzos merged 1 commit intoapache:mainfrom
polyzos merged 1 commit intoapache:mainfrom
Conversation
morazow
force-pushed
the
mor-2636-zk-sasl
branch
4 times, most recently
from
ce0b92a to
9e519af
Compare
affo
suggested changes
Mar 25, 2026
Contributor
affo
left a comment
affo
left a comment
There was a problem hiding this comment.
I really like the switch from "sasl enabled" to "jaas required".
A couple of nits around 🤝
Also, is this rebased?
morazow
force-pushed
the
mor-2636-zk-sasl
branch
3 times, most recently
from
ea03f34 to
b30fe77
Compare
affo
reviewed
Mar 26, 2026
morazow
force-pushed
the
mor-2636-zk-sasl
branch
from
b30fe77 to
faf28e0
Compare
affo
reviewed
Mar 26, 2026
Contributor
affo
left a comment
affo
left a comment
There was a problem hiding this comment.
Some last nits on naming, can you please address?
Approving already but please address 🤝
morazow
force-pushed
the
mor-2636-zk-sasl
branch
from
404cd5b to
1895c2f
Compare
affo
approved these changes
Mar 27, 2026
Contributor
affo
left a comment
affo
left a comment
There was a problem hiding this comment.
Looks perfect to me, thank you!
morazow
force-pushed
the
mor-2636-zk-sasl
branch
from
1895c2f to
bf8be94
Compare
--- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com>
morazow
force-pushed
the
mor-2636-zk-sasl
branch
from
bf8be94 to
78561f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2636
Brief change log
Adds option to enable connections to the Zookeeper nodes via SASL authentication.
Tests
As helm unittests.
API and Format
Documentation
Updated Deploying with Helm document.