Skip to content

[minor][flink] Remove unnecessary java notes #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonardBang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[minor][flink] Remove unnecessary java notes #2444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .../src/main/java/org/apache/fluss/flink/sink/shuffle/StatisticsOrRecordChannelComputer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,10 @@ Map<String, PartitionAssignment> buildAssignment(
String currentKey = null;
long keyRemainingWeight = 0L;
long subtaskRemainingWeight = targetWeightPerSubtask;
// todo: 计算assigned 的 subtasks 列表，并计算每个subtask的 weight
List<Integer> assignedSubtasks = new ArrayList<>();
List<Long> subtaskWeights = new ArrayList<>();
while (mapKeyIterator.hasNext() || currentKey != null) {
// This should never happen because target weight is calculated using ceil function.
// todo: numPartitions是下游的所有id
if (subtaskId >= downstreamParallelism) {
LOG.error(
"Internal algorithm error: exhausted subtasks with unassigned keys left. number of partitions: {}, "
Expand Down