[filesystem] fix the size of fluss-fs-s3 is too big #2419
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.fluss.fs.s3.exception; | ||
|
|
||
| /** Exception thrown when no credentials were found. */ | ||
| public class InvalidCredentialsException extends RuntimeException { | ||
|
|
||
| public static final String E_NO_AWS_CREDENTIALS = "No AWS Credentials"; | ||
|
|
||
| public InvalidCredentialsException(String credentialProvider) { | ||
|
Contributor
There was a problem hiding this comment. I'm curious about the class not found issue. I also check the v0.8 jar for s3 The same with the jar build with this pr So, it looks to me that the same problem will also happen in v0.8, right?
Contributor
Author
There was a problem hiding this comment. Thank you so much for reminding me. I checked it again carefully. hadoop 3.3.4: classDiagram
direction RL
class AmazonClientException
class CredentialInitializationException
class NoAuthWithAWSException
class NoAwsCredentialsException
AmazonClientException --|> CredentialInitializationException
CredentialInitializationException --|> NoAuthWithAWSException
NoAuthWithAWSException --|> NoAwsCredentialsException
hadoop 3.4.0: classDiagram
direction RL
class SdkClientException
class CredentialInitializationException
class NoAuthWithAWSException
class NoAwsCredentialsException
SdkClientException--|> CredentialInitializationException
CredentialInitializationException --|> NoAuthWithAWSException
NoAuthWithAWSException --|> NoAwsCredentialsException
In Hadoop 3.3.4,
Contributor
There was a problem hiding this comment. Thank you for the explantion. |
||
| this(credentialProvider, null); | ||
| } | ||
|
|
||
| public InvalidCredentialsException(String credentialProvider, Throwable throwable) { | ||
| super(credentialProvider + ": " + E_NO_AWS_CREDENTIALS, throwable); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://hadoop.apache.org/release/3.4.1.html
"We have also introduced a lean tar which is a small tar file that does not contain the AWS SDK because the size of AWS SDK is itself 500 MB. This can ease usage for non AWS users. Even AWS users can add this jar explicitly if desired."
If we use 3.4.1, the fat jar won't be included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this should be a better solution. I'll test it and give my conclusion later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luoyuxia Hadoop 3.4.1 provides a "tar" file instead of the "jar" file we usually use. Simply adjusting the version number in the pom.xml file will not reduce the final package size.
I think we still need to manually exclude the fat JAR.