Skip to content

Fix unstable testListRebalanceProgress testcase #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hemanthsavasere wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix unstable testListRebalanceProgress testcase #2386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98e34da
Fix UnstabletestListRebalanceProgress
hemanthsavasere Jan 15, 2026
e36b2bf
Removing non necessary comments
hemanthsavasere Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...uss-flink-common/src/test/java/org/apache/fluss/flink/procedure/FlinkProcedureITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,13 @@ void testListRebalanceProgress() throws Exception {
tableName));
long tableId =
admin.getTableInfo(TablePath.of(DEFAULT_DB, tableName)).get().getTableId();
FLUSS_CLUSTER_EXTENSION.waitUntilTableReady(tableId);
// Use 90 second timeout to handle high load with PERMANENT_OFFLINE server
FLUSS_CLUSTER_EXTENSION.waitUntilTableReady(tableId, Duration.ofSeconds(90));

// Add delay between table creations to reduce coordinator lock contention
if (i < 9) { // Don't delay after last table
Thread.sleep(100);
}
}

// remove tag after crated table.
Expand Down
41 changes: 36 additions & 5 deletions fluss-server/src/test/java/org/apache/fluss/server/testutils/FlussClusterExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,11 +529,16 @@ public void waitUntilAllGatewayHasSameMetadata() {
}
}

/** Wait until all the table assignments buckets are ready for table. */
public void waitUntilTableReady(long tableId) {
/**
* Wait until all replicas in table are ready with configurable timeout.
*
* @param tableId the table id to wait for
* @param timeout the maximum time to wait
*/
public void waitUntilTableReady(long tableId, Duration timeout) {
ZooKeeperClient zkClient = getZooKeeperClient();
retry(
Duration.ofMinutes(1),
timeout,
() -> {
Optional<TableAssignment> tableAssignmentOpt =
zkClient.getTableAssignment(tableId);
Expand All @@ -542,6 +547,15 @@ public void waitUntilTableReady(long tableId) {
});
}

/**
* Wait until all replicas in table are ready with default 1 minute timeout.
*
* @param tableId the table id to wait for
*/
public void waitUntilTableReady(long tableId) {
waitUntilTableReady(tableId, Duration.ofMinutes(1));
}

/**
* Wait until all authorization are synchronized to all tablet servers.
*
Expand Down Expand Up @@ -576,10 +590,17 @@ public void waitUntilAuthenticationSync(Collection<AclBinding> aclBindings, bool
});
}

public void waitUntilTablePartitionReady(long tableId, long partitionId) {
/**
* Wait until all replicas in partition are ready with configurable timeout.
*
* @param tableId the table id
* @param partitionId the partition id
* @param timeout the maximum time to wait
*/
public void waitUntilTablePartitionReady(long tableId, long partitionId, Duration timeout) {
ZooKeeperClient zkClient = getZooKeeperClient();
retry(
Duration.ofMinutes(1),
timeout,
() -> {
Optional<PartitionAssignment> partitionAssignmentOpt =
zkClient.getPartitionAssignment(partitionId);
Expand All @@ -589,6 +610,16 @@ public void waitUntilTablePartitionReady(long tableId, long partitionId) {
});
}

/**
* Wait until all replicas in partition are ready with default 1 minute timeout.
*
* @param tableId the table id
* @param partitionId the partition id
*/
public void waitUntilTablePartitionReady(long tableId, long partitionId) {
waitUntilTablePartitionReady(tableId, partitionId, Duration.ofMinutes(1));
}

private void waitReplicaInAssignmentReady(
ZooKeeperClient zkClient,
TableAssignment tableAssignment,
Expand Down