Skip to content

Conversation

@linguoxuan
Copy link

@linguoxuan linguoxuan commented Jan 23, 2026

Purpose

Linked issue: close #198

add it test for put & get kv for all supported datatypes

Add test(all_supported_datatypes) in kv_table.rs

API and Format

Documentation

@linguoxuan
Copy link
Author

linguoxuan commented Jan 23, 2026

Hi @luoyuxia. Can you take a look with this pr. And I would like to continue with issue199

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a comprehensive integration test for put and get operations on KV tables covering all supported primitive datatypes in the Fluss Rust client.

Changes:

  • Added all_supported_datatypes() integration test in kv_table.rs
  • Tests all primitive data types: boolean, integers (tinyint, smallint, int, bigint), floats (float, double), strings (char, string), decimal, temporal types (date, time, timestamp, timestamp_ltz), and binary types (bytes, binary)
  • Includes testing for null values across all non-primary-key columns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linguoxuan Thanks. LGTM

@luoyuxia
Copy link
Contributor

@linguoxuan But the ci fails

@linguoxuan
Copy link
Author

@linguoxuan But the ci fails

Thanks @luoyuxia for the review. It failed because the cargo fmt check. I have fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add it for put & get kv for all supported datatypes

2 participants