Skip to content

Conversation

@leekeiabstraction
Copy link
Contributor

Purpose

Linked issue: close #182

Brief change log

Add integration tests for KvTable"

  1. Upsert + Lookup
  2. Upsert + Update + Lookup
  3. Upsert + Delete + Lookup
  4. Lookup (non-existent)
  5. Various operations on partial update column
  6. Various operations on multiple PK table

Tests

Test runs locally successfully

@leekeiabstraction
Copy link
Contributor Author

@luoyuxia @fresh-borzoni @AndreaBozzo Appreciate your reviews here

Copy link
Contributor

@fresh-borzoni fresh-borzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leekeiabstraction Thanks for the PR. Left minor comments.
PTAL

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds comprehensive integration tests for KV (Key-Value) table operations in the Fluss client library. The tests verify core KV table functionality including upsert, lookup, update, delete operations, and advanced features like composite primary keys and partial column updates.

Changes:

  • Added new integration test module kv_table.rs with 6 test cases covering all major KV table operations
  • Fixed unnecessary mut qualifier on unused variable in table.rs
  • Registered the new test module in the test suite

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
crates/fluss/tests/test_fluss.rs Added kv_table module to the integration test suite
crates/fluss/tests/integration/table.rs Removed unnecessary mut qualifier from all_ids variable that is never mutated
crates/fluss/tests/integration/kv_table.rs New comprehensive integration test suite for KV table operations including upsert, lookup, update, delete, composite keys, and partial updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leekeiabstraction
Copy link
Contributor Author

@fresh-borzoni TY for your review. Updated, PTAL!

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leekeiabstraction Thanks for the pr. Left minor commet

@leekeiabstraction
Copy link
Contributor Author

Thank you @luoyuxia for the review. Addressed your comment, PTAL!

Copy link
Contributor

@fresh-borzoni fresh-borzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leekeiabstraction LGTM.
Thank you for the PR

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leekeiabstraction Thanks. LGTM

@luoyuxia
Copy link
Contributor

@leekeiabstraction The test fails

@leekeiabstraction
Copy link
Contributor Author

@luoyuxia Thank you, I've updated the polling logic to wait for Tablet server availability as well. PTAL

@luoyuxia luoyuxia merged commit d76eb28 into apache:main Jan 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kv Table Integration tests

4 participants