chore: invalidate leader info on stale metadata error when handling fetch response #189
+185
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohaidao
changed the title
zhaohaidao
changed the title
Contributor
Author
|
@luoyuxia Hi, PTAL if u have time. |
fresh-borzoni
approved these changes
Jan 21, 2026
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@zhaohaidao Thanks for the PR.
LGTM overall. Just minor comment.
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
Thank you for the PR! Left a couple of questions
luoyuxia
reviewed
Jan 22, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@zhaohaidao Thanks for the pr. Left one comment.
added 2 commits
January 23, 2026 10:43
2 tasks
Contributor
Author
|
@luoyuxia @fresh-borzoni @leekeiabstraction Comments are addressed. PTAL if u have time. |
luoyuxia
reviewed
Jan 23, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@zhaohaidao Thanks for the pr. Left minor comments
fresh-borzoni
approved these changes
Jan 23, 2026
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@zhaohaidao Thanks! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Brief change log
Tests
API and Format
Documentation