Skip to content

[FLINK-39921][runtime/tests] Fix the flaky test case ExecutionTimeBasedSlowTaskDetectorTest due to unexepected ComponentMainThreadExecutor setting. #28434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
och5351 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Open

[FLINK-39921][runtime/tests] Fix the flaky test case ExecutionTimeBasedSlowTaskDetectorTest due to unexepected ComponentMainThreadExecutor setting. #28434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...ache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,12 @@
import org.apache.flink.configuration.Configuration;
import org.apache.flink.configuration.SlowTaskDetectorOptions;
import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutorServiceAdapter;
import org.apache.flink.runtime.concurrent.NoMainThreadCheckComponentMainThreadExecutor;
import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
import org.apache.flink.runtime.executiongraph.ExecutionGraph;
import org.apache.flink.runtime.executiongraph.ExecutionGraphTestUtils;
import org.apache.flink.runtime.executiongraph.ExecutionVertex;
import org.apache.flink.runtime.executiongraph.utils.ExecutionUtils;
import org.apache.flink.runtime.io.network.partition.ResultPartitionType;
import org.apache.flink.runtime.jobgraph.DistributionPattern;
import org.apache.flink.runtime.jobgraph.JobGraph;
Expand Down Expand Up @@ -91,7 +93,7 @@ void testAllTasksInCreatedAndNoSlowTasks() throws Exception {
final ExecutionGraph executionGraph =
SchedulerTestingUtils.createScheduler(
jobGraph,
ComponentMainThreadExecutorServiceAdapter.forMainThread(),
new NoMainThreadCheckComponentMainThreadExecutor(),
EXECUTOR_RESOURCE.getExecutor())
.getExecutionGraph();

Expand Down Expand Up @@ -433,12 +435,15 @@ private ExecutionGraph createExecutionGraph(JobVertex... jobVertices) throws Exc
final SchedulerBase scheduler =
SchedulerTestingUtils.createScheduler(
jobGraph,
ComponentMainThreadExecutorServiceAdapter.forMainThread(),
new NoMainThreadCheckComponentMainThreadExecutor(),
EXECUTOR_RESOURCE.getExecutor());

final ExecutionGraph executionGraph = scheduler.getExecutionGraph();

scheduler.startScheduling();
for (ExecutionVertex ev : executionGraph.getAllExecutionVertices()) {
ExecutionUtils.waitForTaskDeploymentDescriptorsCreation(ev);
}
ExecutionGraphTestUtils.switchAllVerticesToRunning(executionGraph);

return executionGraph;
Expand All @@ -450,13 +455,16 @@ private ExecutionGraph createDynamicExecutionGraph(JobVertex... jobVertices) thr
final SchedulerBase scheduler =
new DefaultSchedulerBuilder(
jobGraph,
ComponentMainThreadExecutorServiceAdapter.forMainThread(),
new NoMainThreadCheckComponentMainThreadExecutor(),
EXECUTOR_RESOURCE.getExecutor())
.buildAdaptiveBatchJobScheduler();

final ExecutionGraph executionGraph = scheduler.getExecutionGraph();

scheduler.startScheduling();
for (ExecutionVertex ev : executionGraph.getAllExecutionVertices()) {
ExecutionUtils.waitForTaskDeploymentDescriptorsCreation(ev);
}
ExecutionGraphTestUtils.switchAllVerticesToRunning(executionGraph);

return executionGraph;
Expand Down