[FLINK-35230][table] Split FlinkSqlParserImplTest into smaller test classes#28387
Open
Au-Miner wants to merge 1 commit into
Open
[FLINK-35230][table] Split FlinkSqlParserImplTest into smaller test classes#28387Au-Miner wants to merge 1 commit into
Au-Miner wants to merge 1 commit into
Conversation
Au-Miner
changed the title
Collaborator
github-actions
Bot
added
the
community-reviewed
snuyanzin
reviewed
Jun 14, 2026
Comment on lines
+87
to
+121
| /* | ||
| * This test was backported from Calcite 1.38 (CALCITE-6266). | ||
| * Remove it together with upgrade to Calcite 1.38. | ||
| */ | ||
| @Test | ||
| void testFromValuesWithoutParens() { | ||
| sql("select 1 from ^values^('x')") | ||
| .fails( | ||
| "(?s)Encountered \"values\" at line 1, column 15\\.\n" | ||
| + "Was expecting one of:\n" | ||
| + " \"LATERAL\" \\.\\.\\.\n" | ||
| + " \"TABLE\" \\.\\.\\.\n" | ||
| + " <IDENTIFIER> \\.\\.\\.\n" | ||
| + " <HYPHENATED_IDENTIFIER> \\.\\.\\.\n" | ||
| + " <QUOTED_IDENTIFIER> \\.\\.\\.\n" | ||
| + " <BACK_QUOTED_IDENTIFIER> \\.\\.\\.\n" | ||
| + " <BIG_QUERY_BACK_QUOTED_IDENTIFIER> \\.\\.\\.\n" | ||
| + " <BRACKET_QUOTED_IDENTIFIER> \\.\\.\\.\n" | ||
| + " <UNICODE_QUOTED_IDENTIFIER> \\.\\.\\.\n" | ||
| + " \"\\(\" \\.\\.\\.\n.*" | ||
| + " \"UNNEST\" \\.\\.\\.\n.*"); | ||
| } | ||
|
|
||
| /* | ||
| * This test was backported from Calcite 1.38 (CALCITE-6266). | ||
| * Remove it together with upgrade to Calcite 1.38. | ||
| */ | ||
| @Test | ||
| void testUnnest() { | ||
| sql("select*from unnest(x)").ok("SELECT *\n" + "FROM UNNEST(`X`)"); | ||
| sql("select*from unnest(x) AS T").ok("SELECT *\n" + "FROM UNNEST(`X`) AS `T`"); | ||
| // UNNEST cannot be first word in query | ||
| sql("^unnest^(x)").fails("(?s)Encountered \"unnest\" at.*"); | ||
| // UNNEST with more than one argument | ||
| final String sql = "select * from dept,\n" + "unnest(dept.employees, dept.managers)"; |
Contributor
There was a problem hiding this comment.
can you explain why do we need it given the fact you stopped extending SqlParserTest?
Contributor
There was a problem hiding this comment.
especially comments about 1.38
snuyanzin
reviewed
Jun 14, 2026
|
|
||
| /** Base class providing shared parser test utilities for Flink SQL parser tests. */ | ||
| @Execution(CONCURRENT) | ||
| abstract class FlinkSqlParserTestBase { |
Contributor
There was a problem hiding this comment.
what made you stopped extending SqlParserTest?
snuyanzin
reviewed
Jun 14, 2026
| sql("alter catalog a comment 'comment1'").ok("ALTER CATALOG `A` COMMENT 'comment1'"); | ||
| } | ||
|
|
||
| // END |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Split the monolithic
FlinkSqlParserImplTest(4000+ lines) into smaller, focused test classes to improve maintainability and eliminate the CheckstyleFileLengthsuppression.Brief change log
FlinkSqlParserTestBaseas a shared base class providingfixture(),sql(),expr(),validated()methodsCatalogTest,MetadataTest,CreateTableTest,AlterTableTest,CtasTest,ViewTest,ModelTest,ConnectionTest,ExecuteTest,MiscTestFlinkSqlParserCalciteTestextendingSqlParserTestto restore Calcite standard SQL test coverage (472 inherited tests)FlinkSqlParserUnParserTestusing JUnit 5@Nestedinner classesFlinkSqlParserImplTestFileLengthsuppression fromsuppressions.xmlVerifying this change
This is a pure refactoring — 248 Flink-specific test methods before and after, verified via
diffon extracted method names. The 472 inherited Calcite tests are now covered byFlinkSqlParserCalciteTest.Does this pull request potentially affect one of the following parts
@Public(Evolving): noDocumentation