-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-38825][streaming] Add ordered async batch support for AsyncBatchWaitOperator #27357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
featzhang
wants to merge
5
commits into
apache:master
Choose a base branch
from
featzhang:FLINK-38825-ordered
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
029cedb
[FLINK-38825] Introduce AsyncBatchFunction and AsyncBatchWaitOperator
62bd505
[FLINK-38825] Add time-based batch triggering for AsyncBatchWaitOperator
7d92731
[FLINK-38825] Add ordered async batch support for AsyncBatchWaitOperator
d54ae8a
[FLINK-38825][streaming] Refactor OrderedAsyncBatchWaitOperator to ex…
featzhang 1dcdb79
[FLINK-38825][streaming] Fix test failures in AsyncBatchWaitOperator
featzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
...java/src/main/java/org/apache/flink/streaming/api/functions/async/AsyncBatchFunction.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.streaming.api.functions.async; | ||
|
|
||
| import org.apache.flink.annotation.PublicEvolving; | ||
| import org.apache.flink.api.common.functions.Function; | ||
|
|
||
| import java.io.Serializable; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * A function to trigger Async I/O operations in batches. | ||
| * | ||
| * <p>For each batch of inputs, an async I/O operation can be triggered via {@link | ||
| * #asyncInvokeBatch}, and once it has been done, the results can be collected by calling {@link | ||
| * ResultFuture#complete}. This is particularly useful for high-latency inference workloads where | ||
| * batching can significantly improve throughput. | ||
| * | ||
| * <p>Unlike {@link AsyncFunction} which processes one element at a time, this interface allows | ||
| * processing multiple elements together, which is beneficial for scenarios like: | ||
| * | ||
| * <ul> | ||
| * <li>Machine learning model inference where batching improves GPU utilization | ||
| * <li>External service calls that support batch APIs | ||
| * <li>Database queries that can be batched for efficiency | ||
| * </ul> | ||
| * | ||
| * <p>Example usage: | ||
| * | ||
| * <pre>{@code | ||
| * public class BatchInferenceFunction implements AsyncBatchFunction<String, String> { | ||
| * | ||
| * public void asyncInvokeBatch(List<String> inputs, ResultFuture<String> resultFuture) { | ||
| * // Submit batch inference request | ||
| * CompletableFuture.supplyAsync(() -> { | ||
| * List<String> results = modelService.batchInference(inputs); | ||
| * return results; | ||
| * }).thenAccept(results -> resultFuture.complete(results)); | ||
| * } | ||
| * } | ||
| * }</pre> | ||
| * | ||
| * @param <IN> The type of the input elements. | ||
| * @param <OUT> The type of the returned elements. | ||
| */ | ||
| @PublicEvolving | ||
| public interface AsyncBatchFunction<IN, OUT> extends Function, Serializable { | ||
|
|
||
| /** | ||
| * Trigger async operation for a batch of stream inputs. | ||
| * | ||
| * <p>The implementation should process all inputs in the batch and complete the result future | ||
| * with all corresponding outputs. The number of outputs does not need to match the number of | ||
| * inputs - it depends on the specific use case. | ||
| * | ||
| * @param inputs a batch of elements coming from upstream tasks | ||
| * @param resultFuture to be completed with the result data for the entire batch | ||
| * @throws Exception in case of a user code error. An exception will make the task fail and | ||
| * trigger fail-over process. | ||
| */ | ||
| void asyncInvokeBatch(List<IN> inputs, ResultFuture<OUT> resultFuture) throws Exception; | ||
|
|
||
| // TODO: Add timeout handling in follow-up PR | ||
| // TODO: Add open/close lifecycle methods in follow-up PR | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.