-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-38822] Introduce URL_DECODE_RECURSIVE function for recursive URL decoding #27351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
featzhang
wants to merge
6
commits into
apache:master
Choose a base branch
from
featzhang:FLINK-38822
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ba22401
feat: [FLINK-38822][Table] Support URL_DECODE and URL_DECODE_RECURSIV…
featzhang 31a962c
[FLINK-38822] Add connection pool management options to TritonOptions…
featzhang 40a496b
[FLINK-38822] Add missing import for MaxDepthArgumentTypeStrategy in …
featzhang 226e98c
[FLINK-38822] Fix code formatting in UrlFunctionsITCase
featzhang 886f0eb
[FLINK-38822] Fix UrlFunctionsITCase tests: use testTableApiResult fo…
featzhang 01b989f
[FLINK-38822][Table] Address review feedback: remove unrelated change…
featzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 119 additions & 0 deletions
119
.../java/org/apache/flink/table/types/inference/strategies/MaxDepthArgumentTypeStrategy.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.types.inference.strategies; | ||
|
|
||
| import org.apache.flink.annotation.Internal; | ||
| import org.apache.flink.table.api.DataTypes; | ||
| import org.apache.flink.table.functions.FunctionDefinition; | ||
| import org.apache.flink.table.types.DataType; | ||
| import org.apache.flink.table.types.inference.ArgumentTypeStrategy; | ||
| import org.apache.flink.table.types.inference.CallContext; | ||
| import org.apache.flink.table.types.inference.Signature; | ||
| import org.apache.flink.table.types.logical.LogicalType; | ||
| import org.apache.flink.table.types.logical.LogicalTypeFamily; | ||
| import org.apache.flink.table.types.logical.LogicalTypeRoot; | ||
|
|
||
| import java.util.Optional; | ||
|
|
||
| /** | ||
| * An {@link ArgumentTypeStrategy} that expects a positive integer literal for the {@code maxDepth} | ||
| * parameter of {@code URL_DECODE_RECURSIVE}. | ||
| * | ||
| * <p>The argument must be a compile-time literal (not a dynamic/runtime value), and its value must | ||
| * be strictly positive ({@code > 0}). | ||
| * | ||
| * <p>This strategy uses {@link Number#intValue()} to handle all integer types uniformly, similar to | ||
| * {@link PercentageArgumentTypeStrategy}. | ||
| */ | ||
| @Internal | ||
| public final class MaxDepthArgumentTypeStrategy implements ArgumentTypeStrategy { | ||
|
|
||
| private final boolean expectedNullability; | ||
|
|
||
| public MaxDepthArgumentTypeStrategy(boolean nullable) { | ||
| this.expectedNullability = nullable; | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<DataType> inferArgumentType( | ||
| CallContext callContext, int argumentPos, boolean throwOnFailure) { | ||
| final LogicalType actualType = | ||
| callContext.getArgumentDataTypes().get(argumentPos).getLogicalType(); | ||
|
|
||
| if (!actualType.is(LogicalTypeFamily.INTEGER_NUMERIC)) { | ||
| return callContext.fail(throwOnFailure, "maxDepth must be of INTEGER type."); | ||
| } | ||
| if (!expectedNullability && actualType.isNullable()) { | ||
| return callContext.fail(throwOnFailure, "maxDepth must be of NOT NULL type."); | ||
| } | ||
|
|
||
| // maxDepth must be a compile-time literal; dynamic (runtime) arguments are not accepted. | ||
| if (!callContext.isArgumentLiteral(argumentPos)) { | ||
| return callContext.fail( | ||
| throwOnFailure, | ||
| "maxDepth must be a literal integer, but was a dynamic argument."); | ||
| } | ||
|
|
||
| // Use Number.class to handle all integer types uniformly | ||
| Optional<Number> literalVal = callContext.getArgumentValue(argumentPos, Number.class); | ||
|
|
||
| Integer maxDepth = null; | ||
| if (literalVal.isPresent()) { | ||
| maxDepth = literalVal.get().intValue(); | ||
| } | ||
|
|
||
| if (maxDepth == null || maxDepth <= 0) { | ||
| return callContext.fail( | ||
| throwOnFailure, "maxDepth must be a positive integer, but was: %s.", maxDepth); | ||
| } | ||
|
|
||
| // Preserve the actual integer type to avoid type casting issues at planning time | ||
| return Optional.of(resolveOutputType(actualType.getTypeRoot(), expectedNullability)); | ||
| } | ||
|
|
||
| @Override | ||
| public Signature.Argument getExpectedArgument( | ||
| FunctionDefinition functionDefinition, int argumentPos) { | ||
| return Signature.Argument.of(expectedNullability ? "<INTEGER>" : "<INTEGER NOT NULL>"); | ||
| } | ||
|
|
||
| /** | ||
| * Returns the output {@link DataType} that corresponds to the given integer {@link | ||
| * LogicalTypeRoot}, with the requested nullability. | ||
| */ | ||
| private static DataType resolveOutputType(LogicalTypeRoot root, boolean nullable) { | ||
| final DataType base; | ||
| switch (root) { | ||
| case TINYINT: | ||
| base = DataTypes.TINYINT(); | ||
| break; | ||
| case SMALLINT: | ||
| base = DataTypes.SMALLINT(); | ||
| break; | ||
| case BIGINT: | ||
| base = DataTypes.BIGINT(); | ||
| break; | ||
| case INTEGER: | ||
| default: | ||
| base = DataTypes.INT(); | ||
| break; | ||
| } | ||
| return nullable ? base : base.notNull(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.