Skip to content

Maximum parallelism expansion can be used in MAXIMIZE_UTILISATION mode. #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
low-bee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Maximum parallelism expansion can be used in MAXIMIZE_UTILISATION mode. #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import java.util.SortedMap;

import static org.apache.flink.autoscaler.JobVertexScaler.KeyGroupOrPartitionsAdjustMode.MAXIMIZE_UTILISATION;
import static org.apache.flink.autoscaler.config.AutoScalerOptions.ALL_MAXIMIZE_UTILISATION_USE_MAX_PARALLELISM;
import static org.apache.flink.autoscaler.config.AutoScalerOptions.MAX_SCALE_DOWN_FACTOR;
import static org.apache.flink.autoscaler.config.AutoScalerOptions.MAX_SCALE_UP_FACTOR;
import static org.apache.flink.autoscaler.config.AutoScalerOptions.OBSERVED_SCALABILITY_ENABLED;
Expand Down Expand Up @@ -548,6 +549,9 @@ protected static <KEY, Context extends JobAutoScalerContext<KEY>> int scale(
KeyGroupOrPartitionsAdjustMode mode =
context.getConfiguration().get(SCALING_KEY_GROUP_PARTITIONS_ADJUST_MODE);

var allowMaximizeUtilisationUseMaxParallelism =
context.getConfiguration().get(ALL_MAXIMIZE_UTILISATION_USE_MAX_PARALLELISM);

// When the shuffle type of vertex inputs contains keyBy or vertex is a source,
// we try to adjust the parallelism such that it divides
// the numKeyGroupsOrPartitions without a remainder => data is evenly spread across subtasks
Expand All @@ -557,8 +561,10 @@ protected static <KEY, Context extends JobAutoScalerContext<KEY>> int scale(
// When Mode is MAXIMIZE_UTILISATION , Try to find the smallest parallelism
// that can satisfy the current consumption rate.
(mode == MAXIMIZE_UTILISATION
&& numKeyGroupsOrPartitions / p
< numKeyGroupsOrPartitions / newParallelism)) {
&& (numKeyGroupsOrPartitions / p
< numKeyGroupsOrPartitions / newParallelism
|| (allowMaximizeUtilisationUseMaxParallelism
&& newParallelism == maxParallelism)))) {
return p;
}
}
Expand Down
9 changes: 9 additions & 0 deletions flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,15 @@ private static ConfigOptions.OptionBuilder autoScalerConfig(String key) {
.withDescription(
"How to adjust the parallelism of Source vertex or upstream shuffle is keyBy");

public static final ConfigOption<Boolean> ALL_MAXIMIZE_UTILISATION_USE_MAX_PARALLELISM =
autoScalerConfig("maximize-utilization.use-max-parallelism")
.booleanType()
.defaultValue(false)
.withFallbackKeys(
oldOperatorConfigKey("maximize-utilization.use-max-parallelism"))
.withDescription(
"When use maximize-utilization allow use maximum parallelism for all operators.");

public static final ConfigOption<Boolean> OBSERVED_SCALABILITY_ENABLED =
autoScalerConfig("observed-scalability.enabled")
.booleanType()
Expand Down