[FLINK-39656][hive] Remove deprecated HiveCatalog.getTableFactory() override#42
Open
jlalwani-amazon wants to merge 1 commit into
Open
Conversation
…nd HiveTableFactory The legacy TableFactory interface (now in org.apache.flink.table.legacy) is fully replaced by HiveDynamicTableFactory discovered via SPI through getFactory(). Remove all dead legacy code: - Remove getTableFactory() override from HiveCatalog - Delete HiveTableFactory.java (dead code, never invoked at runtime) - Remove testGenericTable (tested the legacy path) - Fix stray logger reference in HiveFunctionDefinitionFactory - Remove unused legacy imports
jlalwani-amazon
force-pushed
the
flink-39656-remove-gettablefactory
branch
from
b777471 to
1a33783
Compare
davidradl
reviewed
May 15, 2026
davidradl
left a comment
davidradl
left a comment
There was a problem hiding this comment.
we should not remove content until we haver a version change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Remove the legacy
TableFactorycode path that has been fully replaced byHiveDynamicTableFactory(theDynamicTableSourceFactory/DynamicTableSinkFactoryimplementation discovered via SPI throughgetFactory()).The legacy
TableFactoryinterface was moved toorg.apache.flink.table.legacy.factoriesin Flink 2.0, indicating it is deprecated. TheHiveTableFactoryclass andHiveCatalog.getTableFactory()override are dead code — never invoked at runtime since Flink 1.14+ uses the new factory path.JIRA: FLINK-39656
Brief change log
getTableFactory()override fromHiveCatalogHiveTableFactory.java(dead code, never invoked at runtime)testGenericTablefromHiveTableFactoryTest(tested the legacy path)HiveFunctionDefinitionFactoryHiveTableFactoryTestJavadoc to referenceHiveDynamicTableFactoryVerifying this change
CI passed on fork: https://github.com/jlalwani-amazon/flink-connector-hive/actions
Does this pull request potentially affect one of the following parts?