[FLINK-39657][hive] Migrate CatalogTable.of() to CatalogTable.newBuilder()#41
Open
jlalwani-amazon wants to merge 1 commit into
Open
Conversation
…der() Replace all 43 usages of the deprecated CatalogTable.of(schema, comment, partitionKeys, options) with the new builder API: CatalogTable.newBuilder().schema(s).comment(c).partitionKeys(p).options(o).build() CatalogTable.of() will be removed in Flink 2.0 GA.
snuyanzin
reviewed
May 27, 2026
| .build()) | ||
| .comment("values temp table") | ||
| .partitionKeys(new ArrayList<>()) | ||
| .options(Collections.emptyMap()) |
Contributor
There was a problem hiding this comment.
Suggested change
| .options(Collections.emptyMap()) | |
| .options(Map.of()) |
snuyanzin
reviewed
May 27, 2026
| .schema(Schema.newBuilder().build()) | ||
| .comment(null) | ||
| .partitionKeys(new ArrayList<>()) | ||
| .options(Collections.emptyMap()) |
Contributor
There was a problem hiding this comment.
Suggested change
| .options(Collections.emptyMap()) | |
| .options(Map.of()) |
Contributor
There was a problem hiding this comment.
here and in other places
snuyanzin
reviewed
May 27, 2026
Comment on lines
+97
to
+98
| .partitionKeys(Collections.emptyList()) | ||
| .options(Collections.emptyMap()) |
Contributor
There was a problem hiding this comment.
Suggested change
| .partitionKeys(Collections.emptyList()) | |
| .options(Collections.emptyMap()) | |
| .partitionKeys(List.of)) | |
| .options(Map.of()) |
here and in other places
snuyanzin
reviewed
May 27, 2026
| .fromResolvedSchema(resolvedSchema) | ||
| .build()) | ||
| .comment(null) | ||
| .partitionKeys(new ArrayList<>()) |
Contributor
There was a problem hiding this comment.
what is the reason to have new ArrayList() instead of List.of() ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Replace all usages of the deprecated
CatalogTable.of(schema, comment, partitionKeys, options)with the new builder APICatalogTable.newBuilder().schema(s).comment(c).partitionKeys(p).options(o).build().CatalogTable.of()is deprecated and will be removed in Flink 2.0 GA.JIRA: FLINK-39657
Brief change log
Verifying this change
CI passed on fork: https://github.com/jlalwani-amazon/flink-connector-hive/actions
Does this pull request potentially affect one of the following parts?