[FLINK-36594][hive]HiveCatalog should set HiveConf.hiveSiteLocation back

[slankka]

What is the purpose of the change

Using HiveCatalog will cause another hive program lost the hive-site.xml from HiveConf

This change will set HiveConf.hiveSiteLocation back.

This will reduce the complexity caused by the loading order of static configuration files in HiveConf that other big data components depend on.

Brief change log

Visit JIRA ticket to for details.

Originally created from flink repo: apache/flink#25568

[jlalwani-amazon]

Thanks for this fix. the root cause analysis is solid. Setting HiveConf.hiveSiteLocation to null in a static context affects all subsequent HiveConf instances in the JVM, which breaks other Hive-dependent libraries (Hudi, Iceberg, etc.).

One thing I noticed: the same code block also modifies two other static fields that aren't being restored:

HiveConf.setHiveSiteLocation(null);      // line 258 — your PR restores this ✅
HiveConf.setLoadMetastoreConfig(false);  // line 259 — not restored ❌
HiveConf.setLoadHiveServer2Config(false); // line 260 — not restored ❌

These have the same problem. they're static fields that affect all subsequent HiveConf instances in the JVM. If another library expects metastore or HiveServer2 config to be loaded from default locations, setting these to false without restoring them could cause similar issues.

Should we save and restore all three for a complete fix?

[slankka]

@jlalwani-amazon agreed and changed