FINERACT-2640: Extend FeignLoanHelper charge and disbursal methods#5997
Open
DeathGun44 wants to merge 1 commit into
Open
FINERACT-2640: Extend FeignLoanHelper charge and disbursal methods#5997DeathGun44 wants to merge 1 commit into
DeathGun44 wants to merge 1 commit into
Conversation
Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
Contributor
Author
|
Unrelated test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the RestAssured → Feign migration (PR 4 of the roadmap) to Loan Charge Management, Loan State Transitions, and Disbursement Details.
Key Changes
Added Loan Charge Management to
FeignLoanHelper: 11 pure-Feign methods covering the full charge lifecycle on a loan —addLoanCharge,getLoanCharges,getLoanCharge,updateLoanCharge,deleteLoanCharge,getLoanChargeTemplate,waiveLoanCharge,payLoanCharge,adjustLoanCharge, plus convenience overloadsaddSpecifiedDueDateChargeandaddDisbursementCharge.Extended Loan State Transitions: Added the remaining state-transition methods —
closeLoan,closeAsRescheduled,forecloseLoan,assignLoanOfficer,unassignLoanOfficer, andrecoverGuarantee— routing correctly betweenLoansApi(state commands) andLoanTransactionsApi(transactional commands).Added Disbursement Detail & Available Amount Methods:
addAndDeleteDisbursementDetail,getDisbursementDetail,updateDisbursementDate, andmodifyAvailableDisbursementAmountcovering multi-tranche disbursement workflows.Added Reschedule Methods:
createRescheduleRequest,approveRescheduleRequest, and the convenience compositecreateAndApproveRescheduleRequestviaRescheduleLoansApi.Extended
LoanRequestBuilders: Static typed factories for all new operations —rejectLoan,withdrawLoan,closeLoan,forecloseLoan,assignLoanOfficer,unassignLoanOfficer,addLoanCharge(with and without due date),waiveLoanCharge,payLoanCharge,adjustLoanCharge.Updated
FeignLoanTestBase: Exposed delegate methods for all newFeignLoanHelperandFeignChargesHelpercapabilities, keeping test classes thin and consistent with the base pattern.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.