Skip to content

FINERACT-2640: Extend FeignLoanHelper charge and disbursal methods#5997

Open
DeathGun44 wants to merge 1 commit into
apache:developfrom
DeathGun44:FINERACT-2640/feign-loan-charge-and-disbursal-methods
Open

FINERACT-2640: Extend FeignLoanHelper charge and disbursal methods#5997
DeathGun44 wants to merge 1 commit into
apache:developfrom
DeathGun44:FINERACT-2640/feign-loan-charge-and-disbursal-methods

Conversation

@DeathGun44

@DeathGun44 DeathGun44 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Description

Extends the RestAssured → Feign migration (PR 4 of the roadmap) to Loan Charge Management, Loan State Transitions, and Disbursement Details.

Key Changes

Added Loan Charge Management to FeignLoanHelper: 11 pure-Feign methods covering the full charge lifecycle on a loan — addLoanCharge, getLoanCharges, getLoanCharge, updateLoanCharge, deleteLoanCharge, getLoanChargeTemplate, waiveLoanCharge, payLoanCharge, adjustLoanCharge, plus convenience overloads addSpecifiedDueDateCharge and addDisbursementCharge.

Extended Loan State Transitions: Added the remaining state-transition methods — closeLoan, closeAsRescheduled, forecloseLoan, assignLoanOfficer, unassignLoanOfficer, and recoverGuarantee — routing correctly between LoansApi (state commands) and LoanTransactionsApi (transactional commands).

Added Disbursement Detail & Available Amount Methods: addAndDeleteDisbursementDetail, getDisbursementDetail, updateDisbursementDate, and modifyAvailableDisbursementAmount covering multi-tranche disbursement workflows.

Added Reschedule Methods: createRescheduleRequest, approveRescheduleRequest, and the convenience composite createAndApproveRescheduleRequest via RescheduleLoansApi.

Extended LoanRequestBuilders: Static typed factories for all new operations — rejectLoan, withdrawLoan, closeLoan, forecloseLoan, assignLoanOfficer, unassignLoanOfficer, addLoanCharge (with and without due date), waiveLoanCharge, payLoanCharge, adjustLoanCharge.

Updated FeignLoanTestBase: Exposed delegate methods for all new FeignLoanHelper and FeignChargesHelper capabilities, keeping test classes thin and consistent with the base pattern.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
@DeathGun44

Copy link
Copy Markdown
Contributor Author

Unrelated test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant