Skip to content

FINERACT-2642: string param AS header interpolation#5990

Closed
terencemo wants to merge 1 commit into
apache:developfrom
terencemo:fineract-2642-fix0
Closed

FINERACT-2642: string param AS header interpolation#5990
terencemo wants to merge 1 commit into
apache:developfrom
terencemo:fineract-2642-fix0

Conversation

@terencemo

Copy link
Copy Markdown
Contributor

Description

Besides the use of reporting params in report_sql in WHERE clause expressions, there are a couple of standard reports using the pattern ${param} AS header to configure the headers in the tabular output of the SELECT query. Currently no report has string parameters, but if such report is added, then it bypasses the prepared statement execution and needs to be handled safely. This PR implements type checking to only allow date/numeric params for this pattern.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terencemo Would it be possible to cover with integration or E2E tests?

@terencemo

Copy link
Copy Markdown
Contributor Author

LGTM

@terencemo Would it be possible to cover with integration or E2E tests?

Not straightforward because no reports exists with string param in AS header interpolation pattern. Will have to create one for testing this scenario.

@terencemo

Copy link
Copy Markdown
Contributor Author

Closing in favour of #5996

@terencemo terencemo closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants