FINERACT-1788: Split notification queries by read status#5988
Open
udayagiri-sivasai-dev wants to merge 1 commit into
Open
FINERACT-1788: Split notification queries by read status#5988udayagiri-sivasai-dev wants to merge 1 commit into
udayagiri-sivasai-dev wants to merge 1 commit into
Conversation
adamsaghy
requested changes
Jun 16, 2026
adamsaghy
left a comment
adamsaghy
left a comment
Contributor
There was a problem hiding this comment.
@udayagiri-sivasai-dev Please make sure, there is (integration or E2E) test to cover this functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Splits the notification retrieval query into two explicit repository methods:
This removes the nullable
isReadparameter and avoids the EclipseLink parameter-binding issue whennullis passed. The notification read service now calls the appropriate repository method for each use case.Testing
.\gradlew.bat :fineract-provider:compileJava.\gradlew.bat :fineract-provider:compileTestJava.\gradlew.bat spotlessApply.\gradlew.bat :integration-tests:test --tests "*NotificationApiTest*" --no-parallel --max-workers=1git diff --checkgit diff --cached --checkAll completed successfully.