Skip to content

Add support for column index limit in ReadSheet#942

Open
sapienza88 wants to merge 5 commits into
apache:mainfrom
sapienza88:column_support
Open

Add support for column index limit in ReadSheet#942
sapienza88 wants to merge 5 commits into
apache:mainfrom
sapienza88:column_support

Conversation

@sapienza88

@sapienza88 sapienza88 commented Jul 5, 2026

Copy link
Copy Markdown

This PR is for adding support for reading a sheet based on rows AND columns index.
Added the feature in the Sheet module and unit tests

@delei

delei commented Jul 5, 2026

Copy link
Copy Markdown
Member

Welcome to participate in open source contributions.

Please refer to the contribution guide, complete your PR content and modify the commit message format, and provide the unit test code.

@delei delei added the PR: first-time contributor first-time contributor label Jul 5, 2026
@bengbengbalabalabeng

Copy link
Copy Markdown
Contributor

Please refer to the code contribution. Make sure the changes can be compiled and are properly formatted :)

@sapienza88

Copy link
Copy Markdown
Author

Please refer to the code contribution. Make sure the changes can be compiled and are properly formatted :)

No I cannot make sure it compiles on CI, maybe locally but not on CI

@bengbengbalabalabeng

Copy link
Copy Markdown
Contributor

No I cannot make sure it compiles on CI, maybe locally but not on CI

To prevent CI from being blocked by formatting or compilation issues, you can first run mvn clean install -DskipTests and mvn spotless:apply locally to ensure that both the build and formatting pass.

Please refer to the code contribution.

@delei

delei commented Jul 5, 2026

Copy link
Copy Markdown
Member

No I cannot make sure it compiles on CI, maybe locally but not on CI

Hi, may I ask if this is a draft PR?

I haven't seen any complete implementation logic for this new parameter, and there are no use cases of reading Excel files in the unit test code either.

@sapienza88

sapienza88 commented Jul 5, 2026

Copy link
Copy Markdown
Author

No I cannot make sure it compiles on CI, maybe locally but not on CI

Hi, may I ask if this is a draft PR?

I haven't seen any complete implementation logic for this new parameter, and there are no use cases of reading Excel files in the unit test code either.

not a draft PR, i will extend it to add a complete implementation logic for the new parameter, as well as a test based on reading dummy data.

But also it depends what do you mean by "complete implementation logic"?

@delei

delei commented Jul 5, 2026

Copy link
Copy Markdown
Member

not a draft PR, i will extend it to add a complete implementation logic for the new parameter, as well as a test based on reading dummy data.

It's okay. Please continue to develop and refine this PR, and conduct unit tests in the local environment. When a PR is ready for code review by community members, you can leave a message to let us know.

@delei delei added the PR: developing This feature will be added in future releases label Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: developing This feature will be added in future releases PR: first-time contributor first-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants