Add support for column index limit in ReadSheet#942
Conversation
|
Welcome to participate in open source contributions. Please refer to the contribution guide, complete your PR content and modify the commit message format, and provide the unit test code. |
|
Please refer to the code contribution. Make sure the changes can be compiled and are properly formatted :) |
No I cannot make sure it compiles on CI, maybe locally but not on CI |
To prevent CI from being blocked by formatting or compilation issues, you can first run Please refer to the code contribution. |
Hi, may I ask if this is a draft PR? I haven't seen any complete implementation logic for this new parameter, and there are no use cases of reading Excel files in the unit test code either. |
not a draft PR, i will extend it to add a complete implementation logic for the new parameter, as well as a test based on reading dummy data. But also it depends what do you mean by "complete implementation logic"? |
It's okay. Please continue to develop and refine this PR, and conduct unit tests in the local environment. When a PR is ready for code review by community members, you can leave a message to let us know. |
This PR is for adding support for reading a sheet based on rows AND columns index.
Added the feature in the Sheet module and unit tests