fix: correct moveOverlap label offsets and keep labels within coordinate system (#21461) #21503
Open
SakshamSinghal20 wants to merge 1 commit intoapache:masterfrom
Open
fix: correct moveOverlap label offsets and keep labels within coordinate system (#21461) #21503SakshamSinghal20 wants to merge 1 commit intoapache:masterfrom
SakshamSinghal20 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
Author
|
@plainheart @100pah could you please review this at your convenience? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes label positioning bugs in heatmap series when using
labelLayout.moveOverlap, ensuring labels only shift when overlapping and stay within coordinate system bounds.Fixed issues
Details
Before: What was the problem?
When using
series.labelLayout: { moveOverlap: 'shiftX' | 'shiftY' }on Heatmap series with value or time axes, two issues occurred:Root causes:
LabelManager.layout()used canvas dimensions instead of coordinate system boundsshiftLayoutOnXY()always eliminated gaps, shifting labels even without overlapsAfter: How does it behave after the fixing?
Fixed behavior:
Implementation:
LabelManager.tsto detect Cartesian systems and use plotting area bounds viagetArea()labelLayoutHelper.tsto add overlap detection; if no overlaps, only clamp to boundsChanges:
src/label/LabelManager.ts: AddedgetCoordSysBounds()helper (28 lines)src/label/labelLayoutHelper.ts: Added overlap detection (35 lines)test/heatmap-label-moveOverlap.html: New test fileDocument Info
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/heatmap-label-moveOverlap.htmltest/issue-21461-fix-demo.htmlMerging options
Other information
Fully backward compatible, minimal changes (63 lines), tested with value/time/category axes.