Fix treemap select action collision when node names are duplicated (Fixes issue #21480)#21481
Open
ChimdumebiNebolisa wants to merge 1 commit intoapache:masterfrom
Open
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes treemap
dispatchAction({ type: 'select', dataIndex })so that selection targets a single node even when multiple nodes share the same name.Fixed issues
Details
Before: What was the problem?
When using
dispatchAction({ type: 'select', dataIndex })on a treemap that contains multiple nodes with the samenameand no explicitid, the selection logic could select multiple nodes or behave inconsistently.This happened because the internal selection state (
selectedMap) was keyed by nodenamefirst, causing key collisions when names were duplicated.After: How does it behave after the fixing?
Selection is now keyed by
data.getId(dataIndex), which is guaranteed to be unique.As a result:
dispatchAction({ type: 'select', dataIndex })deterministically selects only the intended treemap nodeA minimal reproduction case (
test/treemap-select-21480.html) confirms that only the targeted node is selected.Document Info
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information
N/A