fix(legend): fallback to horizontal if orient is invalid#21450
fix(legend): fallback to horizontal if orient is invalid#21450dilipkumar6306316-art wants to merge 5 commits intoapache:masterfrom
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
plainheart
left a comment
There was a problem hiding this comment.
- Please do not commit the files in the
distfolder. - Please do not use any formatter tool.
- Please recover all the changes that are not related to your fix.
|
I suggest not fixing this case, as invalid |
|
Thanks for the clarification and for sharing the context. I checked the referenced issue (#16912) as well and understand that fixing this Given this context, I understand that fixing this case in code might not be |
Summary
This PR fixes a bug in the Legend component (#21400) where providing an invalid
legend.orientvalue caused unexpected width/height behavior in scroll legends.Changes
legend.orientindexhorizontalandverticalorient values remains unchangedTesting
Related Issue
Closes #21400