Add regression test for NettyChannel cleanup on repeated disconnects#16068
Add regression test for NettyChannel cleanup on repeated disconnects#16068SURYAS1306 wants to merge 1 commit intoapache:3.3from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16068 +/- ##
============================================
- Coverage 60.75% 60.75% -0.01%
+ Complexity 11751 11750 -1
============================================
Files 1951 1951
Lines 88992 88992
Branches 13418 13418
============================================
- Hits 54070 54063 -7
- Misses 29362 29367 +5
- Partials 5560 5562 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| headerReceived = true; | ||
| transportError = validateHeaderStatus(headers); | ||
|
|
||
| if (transportError != null) { |
|
Thanks for pointing this out. That change is not related to the NettyChannel regression test and should not be part of this PR. It was brought in unintentionally from earlier local branch history. I’ll clean up the PR to keep it focused only on the NettyChannel regression test. |
52e74ff to
5f7c374
Compare
|
Thanks for the review @zrlw , I’ve cleaned up the PR history to remove the unrelated commits. All checks pass locally and in CI. |
What is the purpose of the change?
This PR adds a regression test to validate the NettyChannel lifecycle cleanup behavior.
The test ensures that channels can be safely removed and re-created across repeated
add/remove cycles, preventing channel map leaks observed in issue #16054.
What is changed?
NettyChannelTestto cover repeated channel add/remove scenarios.Checklist