Open
Conversation
LI123456mo
force-pushed
the
feature/type-utils-test
branch
2 times, most recently
from
682ed7b to
f34248a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16056 +/- ##
==========================================
Coverage 60.74% 60.75%
- Complexity 11742 11755 +13
==========================================
Files 1949 1952 +3
Lines 88902 89012 +110
Branches 13409 13421 +12
==========================================
+ Hits 54001 54076 +75
- Misses 29336 29369 +33
- Partials 5565 5567 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
heliang666s
requested changes
Jan 28, 2026
...-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConnectionHandler.java
Outdated
Show resolved
Hide resolved
LI123456mo
force-pushed
the
feature/type-utils-test
branch
from
f34248a to
fa7420c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces unit test coverage for the TypeUtils interface. Since this utility is fundamental for handling Java Generics and ParameterizedTypes within Dubbo, ensuring its reliability is crucial for data mapping and serialization.
Key Coverage Areas:
Type Validation: Verified isParameterizedType correctly distinguishes between standard classes and generic types.
Class Extraction: Tested getRawClass to ensure base classes are correctly extracted from complex generic signatures.
Generics Discovery: Used static inner classes (e.g., StringList, StringIntegerMap) to verify that findActualTypeArguments accurately identifies generic arguments like across interfaces and superclasses.
Metadata: Validated getClassName for accurate type string representation.
Verification:
Successfully ran mvn clean test -Dtest=TypeUtilsTest -pl dubbo-common.
Verified code style via mvn spotless:apply -pl dubbo-common.