Fix AwaitingNonWebApplicationListener await with parent context#15981
Open
ishankhemani wants to merge 2 commits intoapache:3.3from
Open
Fix AwaitingNonWebApplicationListener await with parent context#15981ishankhemani wants to merge 2 commits intoapache:3.3from
ishankhemani wants to merge 2 commits intoapache:3.3from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15981 +/- ##
============================================
- Coverage 60.72% 58.75% -1.98%
+ Complexity 11734 15 -11719
============================================
Files 1949 1949
Lines 88799 88799
Branches 13391 13392 +1
============================================
- Hits 53922 52172 -1750
- Misses 29338 30972 +1634
- Partials 5539 5655 +116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zrlw
changed the title
Contributor
|
This pr might conflict with current shutdown hook mechanism, many providers of dubbo-sample projects shutdown immediately after launch, pls check |
ishankhemani
force-pushed
the
fix-Await-Parent-ConText
branch
from
8923fdb to
ddec94d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #13722
Description
AwaitingNonWebApplicationListener should only enter the await state for the
root, non-web ApplicationContext.
When a parent–child context hierarchy is present, the listener must not await
during child context shutdown.
This PR ensures the listener behaves correctly with multiple non-web
application contexts and adds a focused regression test to cover this scenario.
Changes
Prevent awaiting logic from being triggered by child ApplicationContext
Add unit test for non-web parent–child context lifecycle
Testing
Added testMultipleContextNonWebApplication
Tests pass locally
Fixes #13722
please review it sir when you get time @AlbumenJ @RainYuY