[Fix-15886] Fix thread leak in NacosRegistry using Double-Checked Locking

[QiuYucheng2003]

What is the purpose of the change

Fixes #15886

This PR fixes a thread leak issue in NacosRegistry.java.

The method scheduleServiceNamesLookup had a race condition where multiple threads could pass the if (scheduledExecutorService == null) check simultaneously, leading to the creation of multiple ScheduledExecutorService instances that were never shut down.

Brief changelog

• Applied Double-Checked Locking in scheduleServiceNamesLookup to ensure the executor service is instantiated safely and only once.

Verifying this change

• Verified via code logic analysis (fixing the race condition).
• Existing unit tests should pass.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.74%. Comparing base (be40746) to head (d5ff216).

Files with missing lines	Patch %	Lines
...org/apache/dubbo/registry/nacos/NacosRegistry.java	0.00%	17 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##                3.3   #15915   +/-   ##
=========================================
  Coverage     60.74%   60.74%           
+ Complexity    11754    11746    -8     
=========================================
  Files          1949     1949           
  Lines         88898    88901    +3     
  Branches      13407    13408    +1     
=========================================
+ Hits          53998    54001    +3     
- Misses        29337    29342    +5     
+ Partials       5563     5558    -5     

Flag	Coverage Δ
integration-tests-java21	32.28% <0.00%> (+0.05%)	⬆️
integration-tests-java8	32.29% <0.00%> (-0.09%)	⬇️
samples-tests-java21	32.13% <0.00%> (+<0.01%)	⬆️
samples-tests-java8	29.72% <0.00%> (+0.03%)	⬆️
unit-tests-java11	59.00% <0.00%> (-0.01%)	⬇️
unit-tests-java17	58.51% <0.00%> (-0.01%)	⬇️
unit-tests-java21	58.50% <0.00%> (+<0.01%)	⬆️
unit-tests-java25	58.46% <0.00%> (-0.01%)	⬇️
unit-tests-java8	59.00% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[QiuYucheng2003]

Regarding the Codecov report: Since this PR fixes a race condition via Double-Checked Locking, it is difficult to reproduce the concurrency scenario deterministically in unit tests, hence the 0% coverage on the new lines

[Copilot]

Pull request overview

This PR fixes a thread leak issue in NacosRegistry caused by a race condition during lazy initialization of the scheduledExecutorService. The fix implements double-checked locking to ensure the executor service is created only once, even when multiple threads attempt concurrent initialization.

Key Changes:

• Applied double-checked locking pattern in scheduleServiceNamesLookup method to prevent multiple executor service instances from being created
• Added synchronized block around executor initialization to ensure thread-safe singleton instantiation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Potential race condition. This assignment to scheduledExecutorService is visible to other threads before the subsequent statements are executed.

[QiuYucheng2003]

Verified that scheduledExecutorService is declared as volatile, so this DCL pattern is thread-safe.