refactor: remove config package from dubbogo-cli sample generator#3218
Merged
Alanxtl merged 6 commits intoapache:developfrom Feb 19, 2026
Merged
Conversation
CAICAIIs
force-pushed
the
feature/remove-config-from-dubbogo-cli-sample-generator
branch
from
9c37410 to
7f9e32f
Compare
- Migrate sample generator from config-based to programmatic API - Update client template to use client.NewClient() - Update server template to use server.NewServer() - Remove conf/dubbogo.yaml configuration files - Disable config file generation (comment out init() in gen_c_conf.go and gen_s_conf.go) - Fix import order to match project standards - Handle license suffix in constants.go using strings.TrimSuffix - Update README.md and README_CN.md documentation
CAICAIIs
force-pushed
the
feature/remove-config-from-dubbogo-cli-sample-generator
branch
from
60be442 to
b544939
Compare
Fix test failures by adding blank lines between the license header and the generated code content in all template files: - api.go: Add blank line at beginning of apiFile constant - api_tripe.go: Add blank line at beginning of apiTripleFile constant - proto.go: Add blank line at beginning of protoFile constant - gen_client.go: Add blank line at beginning of clientCode constant and add newline separator in concatenation - gen_server.go: Add blank line at beginning of serverCode constant and add newline separator in concatenation All tests now pass with these changes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3218 +/- ##
===========================================
+ Coverage 46.76% 47.95% +1.18%
===========================================
Files 295 463 +168
Lines 17172 33743 +16571
===========================================
+ Hits 8031 16182 +8151
- Misses 8287 16253 +7966
- Partials 854 1308 +454 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3204
Checklist
develop