refactor(triple): upgrade triple client to service-level abstraction

[Aetherance]

Background

Currently, triple_protocol.Client is designed as a procedure-level client (one client instance per RPC method), which leads to:

• High memory overhead: O(methods) client instances per service
• Complex management: clientManager maintains a map[string]*Client to track method-level clients
• Duplicated logic: Separate code paths for IDL and non-IDL modes, including reflection-based method discovery

This design differs from the gRPC client model, which uses a service-level client, where a single client instance manages all RPC methods of a service.

---

Changes

This PR refactors triple_protocol.Client to a service-level architecture.

1. Core API Changes (protocol/triple/triple_protocol/client.go)

• Add method string parameter to all Call* methods:

  • CallUnary(ctx, req, res, method)
  • CallClientStream(ctx, method)
  • CallServerStream(ctx, req, method)
  • CallBidiStream(ctx, method)

• Introduce buildMethodLevelReqSpec() to construct method-level request specs from a service-level spec

• Add normalizeClientProcedure() for consistent URL path handling

2. Client Manager Simplification (protocol/triple/client.go)

Refactor clientManager from a method-level to a service-level structure:

// Before
type clientManager struct {
    isIDL      bool
    triClients map[string]*tri.Client
}

// After
type clientManager struct {
    isIDL     bool
    triClient *tri.Client
}

• Remove the getClient(method) helper
• Unify IDL and non-IDL client creation logic
• Update all call paths to explicitly pass the method parameter

3. Bug Fix (protocol/triple/triple_protocol/duplex_http_call.go)

• Bind url.Path = spec.Procedure to ensure requests are routed to the correct RPC method
• Improves correctness in duplex streaming scenarios

4. Test Updates

• Update test cases to align with the service-level client model
• Ensure coverage for updated client and manager logic

---

Impact

Memory & Performance

• Client instances per service: O(methods) → O(1)
• Code changes: Net -108 lines (7 files changed, 133 insertions, 241 deletions)

API Compatibility

• Breaking Change: triple_protocol.Client APIs now require an explicit method parameter
• Limited impact: triple_protocol is primarily an internal API
• Higher-level APIs unchanged: client.Client and client.Connection remain compatible

---

Migration Guide

For direct users of triple_protocol.Client (rare):

// Before
client := tri.NewClient(httpClient, "http://host/service/Method", opts...)
err := client.CallUnary(ctx, req, res)

// After
client := tri.NewClient(httpClient, "http://host/service", opts...)
err := client.CallUnary(ctx, req, res, "Method")

[Aetherance]

issue #3087

[CAICAIIs]

please fix the code format

[CAICAIIs]

Maybe it would be better to put TriClientPool in a separate new file instead of cramming it into the existing client.go?

[Aetherance]

This PR is still in progress. I’ll update it once it's ready for review.

[marsevilspirit]

Fix ci error.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 52.23881% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.04%. Comparing base (60d1c2a) to head (a926b9c).
⚠️ Report is 713 commits behind head on develop.

Files with missing lines	Patch %	Lines
protocol/triple/triple_protocol/client.go	61.70%	9 Missing and 9 partials ⚠️
...roto/connect/ping/v1/pingv1connect/ping.connect.go	0.00%	8 Missing ⚠️
protocol/triple/client.go	40.00%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3086      +/-   ##
===========================================
+ Coverage    46.76%   48.04%   +1.27%     
===========================================
  Files          295      460     +165     
  Lines        17172    33145   +15973     
===========================================
+ Hits          8031    15924    +7893     
- Misses        8287    15926    +7639     
- Partials       854     1295     +441     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Aetherance]

@marsevilspirit review

[Aetherance]

@marsevilspirit done

[marsevilspirit]

Write a performance test to demonstrate that your change can improve the throughput of triple.

[nanjiek]

Why delete the error message about base and interface?

[Aetherance]

Thanks for reviewing. I will fix later

[Alanxtl]

protocol/triple/client_pool.go needs sound unit tests, please write a test file for it

[Alanxtl]

benchmark 能不能加 大流量 和 并发量高一些 的场景，看一下这两种场景中修改前后的benchmark结果

[marsevilspirit]

Performance test reference: https://github.com/marsevilspirit/dubbo-go-benchmark

[Aetherance]

benchmark 能不能加 大流量 和 并发量高一些 的场景，看一下这两种场景中修改前后的benchmark结果

ok

[Aetherance]

Performance test reference: https://github.com/marsevilspirit/dubbo-go-benchmark

got it

[marsevilspirit]

Is this PR process still ongoing?

[Aetherance]

This PR originally implemented a TriClientPool, but the design was refactored to a service-level client.
This simplifies management and reduces memory overhead.

[Aetherance]

@marsevilspirit

[AlexStocks]

@Aetherance please fix the file confliction
@marsevilspirit please review the latest changes.

[Aetherance]

@AlexStocks confliction fixed

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud