Skip to content

feat: add Chinese localization for README files#80

Open
xinxingi wants to merge 1 commit intoapache:masterfrom
xinxingi:master-zh-localization
Open

feat: add Chinese localization for README files#80
xinxingi wants to merge 1 commit intoapache:masterfrom
xinxingi:master-zh-localization

Conversation

@xinxingi
Copy link
Copy Markdown

#79

Copilot AI review requested due to automatic review settings March 27, 2026 02:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Simplified Chinese documentation support by introducing a Chinese README and exposing a language switcher in the main README, aligning with Issue #79’s request for bilingual docs entry points.

Changes:

  • Added a new Simplified Chinese README at docs/zh-CN/README.zh-CN.md.
  • Added an English/简体中文 language switcher link near the top of README.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
docs/zh-CN/README.zh-CN.md Adds a full Simplified Chinese README translation/content for the project docs.
README.md Adds a top-of-file language navigation link to the Chinese README.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

```python
auth_info = {
"type": "token",
"token": "your_jwt_token",
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Token auth example, type is "token" but the placeholder value is "your_jwt_token", which is confusing and suggests the wrong credential type. Update the placeholder to reflect a token value (or change the example to JWT auth if that’s what’s intended).

Suggested change
"token": "your_jwt_token",
"token": "your_access_token",

Copilot uses AI. Check for mistakes.
├── logs/ # 日志目录
├── tokens.json # Token 配置文件
├── README.md # 英文文档
├── README.zh-CN.md # 中文文档
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory tree example lists a top-level README.zh-CN.md, but this PR adds the Chinese README under docs/zh-CN/README.zh-CN.md and there is no README.zh-CN.md at repo root. Please update this tree to match the actual file locations to avoid confusing readers.

Suggested change
├── README.zh-CN.md # 中文文档
├── docs/ # 文档目录
│ └── zh-CN/
│ └── README.zh-CN.md # 中文文档

Copilot uses AI. Check for mistakes.

## License

本项目基于 Apache 2.0 License 发布,详见 `LICENSE` 文件。
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section refers to a LICENSE file, but the repository contains LICENSE.txt. Please reference the correct filename so users can find the license text easily.

Suggested change
本项目基于 Apache 2.0 License 发布,详见 `LICENSE` 文件。
本项目基于 Apache 2.0 License 发布,详见 `LICENSE.txt` 文件。

Copilot uses AI. Check for mistakes.
pip install doris-mcp-server

# 安装指定版本
pip install doris-mcp-server==0.6.0
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pinned install example uses doris-mcp-server==0.6.0, but the project version in pyproject.toml is 0.6.1. This makes the Chinese README (and potentially its “v0.6.0” framing) immediately outdated/misleading; consider updating the version references to match the current release/version declared in the repo.

Suggested change
pip install doris-mcp-server==0.6.0
pip install doris-mcp-server==0.6.1

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants