Skip to content

[fix] Use cursor.description to detect result-returning queries #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonasbrami wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix] Use cursor.description to detect result-returning queries #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions doris_mcp_server/utils/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,15 +95,9 @@ async def execute(self, sql: str, params: tuple | None = None, auth_context=None
async with self.connection.cursor(aiomysql.DictCursor) as cursor:
await cursor.execute(sql, params)

# Check if it's a query statement (statement that returns result set)
# FIX for Issue #62 Bug 5: Added WITH support for Common Table Expressions (CTE)
sql_upper = sql.strip().upper()
if (sql_upper.startswith("SELECT") or
sql_upper.startswith("SHOW") or
sql_upper.startswith("DESCRIBE") or
sql_upper.startswith("DESC") or
sql_upper.startswith("EXPLAIN") or
sql_upper.startswith("WITH")): # FIX: Support CTE queries
# cursor.description is set by the DB driver for any statement that returns rows,
# avoiding a brittle hardcoded keyword list (e.g. missing WITH/CTE, comments before keywords).
if cursor.description:
data = await cursor.fetchall()
row_count = len(data)
else:
Expand Down