[DSIP-105][Api-server] Sensitive Variable Support — Masking in API/UI & Encrypted Storage#18329
Open
det101 wants to merge 3 commits into
Open
[DSIP-105][Api-server] Sensitive Variable Support — Masking in API/UI & Encrypted Storage#18329det101 wants to merge 3 commits into
det101 wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
decrypted sensitive values in prepareParamsMap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES, The code was generated with AI assistance.
Purpose of the pull request
This PR implements DSIP-105 / #17937: support for sensitive workflow variables (global and local parameters).
Users can mark a parameter as sensitive=true. The system then:
masks values as ****** in API/UI responses
encrypts sensitive values before persisting to DB (reusing PasswordUtils and datasource.encryption.enable)
merges ****** on save/update to keep the existing secret
decrypts sensitive values at runtime so tasks receive real values in prepareParamsMap
masks sensitive values in task stdout logs (task-scoped dynamic masking with cleanup after task finish)
Closes #17937.
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
Unit tests
API integration tests (standalone)
Manual verification
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md