Skip to content

[Fix-18132][API] Sync workflow definition version back after create/update#18133

Merged
SbloodyS merged 1 commit intoapache:devfrom
wcmolin:fix/18132-workflow-definition-version-sync
Apr 3, 2026
Merged

[Fix-18132][API] Sync workflow definition version back after create/update#18133
SbloodyS merged 1 commit intoapache:devfrom
wcmolin:fix/18132-workflow-definition-version-sync

Conversation

@wcmolin
Copy link
Copy Markdown
Contributor

@wcmolin wcmolin commented Apr 3, 2026

The version field in the WorkflowDefinition object returned by create and update API was always 0, since the insertVersion returned by processService.saveWorkflowDefine() was never synced back to the object.

Was this PR generated or assisted by AI?

Yes

Purpose of the pull request

fix #18132

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add UT for this. @wcmolin

@SbloodyS SbloodyS added the bug Something isn't working label Apr 3, 2026
@SbloodyS SbloodyS added this to the 3.4.2 milestone Apr 3, 2026
…pdate

The version field in the WorkflowDefinition object returned by create and
update API was always 0, since the insertVersion returned by
processService.saveWorkflowDefine() was never synced back to the object.
@wcmolin wcmolin force-pushed the fix/18132-workflow-definition-version-sync branch from 329ec5f to 76dedea Compare April 3, 2026 03:30
@wcmolin wcmolin requested a review from caishunfeng as a code owner April 3, 2026 03:30
@github-actions github-actions bot added the test label Apr 3, 2026
@wcmolin
Copy link
Copy Markdown
Contributor Author

wcmolin commented Apr 3, 2026

Done, @SbloodyS

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS merged commit 7022d56 into apache:dev Apr 3, 2026
121 of 122 checks passed
@wcmolin wcmolin deleted the fix/18132-workflow-definition-version-sync branch April 3, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][API] WorkflowDefinition version is not synced back after create/update, always returns 0

2 participants