Skip to content

[Improvement-18127][Master] Remove the redundant workflow completion check when handling workflow timeout events #18128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SbloodyS merged 2 commits into from
Apr 2, 2026
Merged

[Improvement-18127][Master] Remove the redundant workflow completion check when handling workflow timeout events #18128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47975de
Remove the redundant workflow completion check when handling workflow…
Apr 2, 2026
ffbdb10
Merge branch 'dev' into Improvement-18127
SbloodyS Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ...server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

import org.apache.dolphinscheduler.dao.entity.WorkflowInstance;
import org.apache.dolphinscheduler.server.master.engine.ILifecycleEventType;
import org.apache.dolphinscheduler.server.master.engine.graph.IWorkflowExecutionGraph;
import org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.WorkflowLifecycleEventType;
import org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.event.WorkflowTimeoutLifecycleEvent;
import org.apache.dolphinscheduler.server.master.engine.workflow.runnable.IWorkflowExecutionRunnable;
Expand All @@ -46,12 +45,6 @@ public WorkflowTimeoutLifecycleEventHandler(final WorkflowAlertManager workflowA
public void handle(final IWorkflowStateAction workflowStateAction,
final IWorkflowExecutionRunnable workflowExecutionRunnable,
final WorkflowTimeoutLifecycleEvent workflowTimeoutLifecycleEvent) {
final IWorkflowExecutionGraph workflowExecutionGraph = workflowExecutionRunnable.getWorkflowExecutionGraph();
if (workflowExecutionGraph.isAllTaskExecutionRunnableChainFinish()) {
// all the TaskExecutionRunnable chain in the graph is finish, means the workflow is already finished.
return;
}

final WorkflowInstance workflowInstance = workflowExecutionRunnable.getWorkflowInstance();
final boolean shouldSendAlert = workflowInstance.getWarningGroupId() != null;

Expand Down
Loading