Skip to content

[Chore][Improvement][Worker] Centralize varPool sync after physical task execution #18071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mrhs121 wants to merge 2 commits into
base: dev
Choose a base branch
from
+1 −0
Open

[Chore][Improvement][Worker] Centralize varPool sync after physical task execution #18071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3e378e
[Improvement][Worker] Centralize varPool sync after physical task exe…
Mrhs121 Mar 16, 2026
3069bf2
Merge branch 'dev' into fix-all-varpool
SbloodyS Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...rc/main/java/org/apache/dolphinscheduler/server/worker/executor/PhysicalTaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ public void updateTaskInstanceInfo(final int taskInstanceId) {
taskExecutorEventBus.publish(TaskExecutorRuntimeContextChangedLifecycleEvent.of(taskExecutor));
}
});
this.getTaskExecutionContext().setVarPool(this.physicalTask.getParameters().getVarPool());
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to add this kind of lifecycle method at AbstractTask(maybe names ITaskPlugin in the future).
I plan to refactor some of the TaskPlugin interfaces in version 3.5.0.

}

@Override
Expand Down
Loading